Remove unused argument from ginInsertCleanup()

It's an oversight in commit dc943ad.

diff --git a/src/backend/access/gin/ginfast.c b/src/backend/access/gin/ginfast.c
index 88e36211edf6f3acb2c071075559f6e5f766ddd3..681ce098144f41600dd47684c5b22994e5e7bacd 100644 (file)
--- a/src/backend/access/gin/ginfast.c
+++ b/src/backend/access/gin/ginfast.c
@@ -434,7 +434,7 @@ ginHeapTupleFastInsert(GinState *ginstate, GinTupleCollector *collector)
    END_CRIT_SECTION();
 
    if (needCleanup)
-       ginInsertCleanup(ginstate, false, true, NULL);
+       ginInsertCleanup(ginstate, true, NULL);
 }
 
 /*
@@ -732,9 +732,6 @@ processPendingPage(BuildAccumulator *accum, KeyArray *ka,
  * action of removing a page from the pending list really needs exclusive
  * lock.
  *
- * vac_delay indicates that ginInsertCleanup should call
- * vacuum_delay_point() periodically.
- *
  * fill_fsm indicates that ginInsertCleanup should add deleted pages
  * to FSM otherwise caller is responsible to put deleted pages into
  * FSM.
@@ -743,8 +740,7 @@ processPendingPage(BuildAccumulator *accum, KeyArray *ka,
  */
 void
 ginInsertCleanup(GinState *ginstate,
-                bool vac_delay, bool fill_fsm,
-                IndexBulkDeleteResult *stats)
+                bool fill_fsm, IndexBulkDeleteResult *stats)
 {
    Relation    index = ginstate->index;
    Buffer      metabuffer,

diff --git a/src/backend/access/gin/ginvacuum.c b/src/backend/access/gin/ginvacuum.c
index f0a246f3f3c394f5c1d0292a2958bb3d12ee6f60..6a4b98a4e7e5d74b69756d8085527a2128b9b025 100644 (file)
--- a/src/backend/access/gin/ginvacuum.c
+++ b/src/backend/access/gin/ginvacuum.c
@@ -541,7 +541,7 @@ ginbulkdelete(IndexVacuumInfo *info, IndexBulkDeleteResult *stats,
        /* Yes, so initialize stats to zeroes */
        stats = (IndexBulkDeleteResult *) palloc0(sizeof(IndexBulkDeleteResult));
        /* and cleanup any pending inserts */
-       ginInsertCleanup(&gvs.ginstate, true, false, stats);
+       ginInsertCleanup(&gvs.ginstate, false, stats);
    }
 
    /* we'll re-count the tuples each time */
@@ -654,7 +654,7 @@ ginvacuumcleanup(IndexVacuumInfo *info, IndexBulkDeleteResult *stats)
        if (IsAutoVacuumWorkerProcess())
        {
            initGinState(&ginstate, index);
-           ginInsertCleanup(&ginstate, true, true, stats);
+           ginInsertCleanup(&ginstate, true, stats);
        }
        return stats;
    }
@@ -667,7 +667,7 @@ ginvacuumcleanup(IndexVacuumInfo *info, IndexBulkDeleteResult *stats)
    {
        stats = (IndexBulkDeleteResult *) palloc0(sizeof(IndexBulkDeleteResult));
        initGinState(&ginstate, index);
-       ginInsertCleanup(&ginstate, true, false, stats);
+       ginInsertCleanup(&ginstate, false, stats);
    }
 
    memset(&idxStat, 0, sizeof(idxStat));

diff --git a/src/include/access/gin_private.h b/src/include/access/gin_private.h
index fe04aaa6ef2111c1dab28af3c7806c7783903f93..695959c5b184e8895891a60e1160229927ffa6de 100644 (file)
--- a/src/include/access/gin_private.h
+++ b/src/include/access/gin_private.h
@@ -946,7 +946,7 @@ extern void ginHeapTupleFastCollect(GinState *ginstate,
                        OffsetNumber attnum, Datum value, bool isNull,
                        ItemPointer ht_ctid);
 extern void ginInsertCleanup(GinState *ginstate,
-                bool vac_delay, bool fill_fsm, IndexBulkDeleteResult *stats);
+                bool fill_fsm, IndexBulkDeleteResult *stats);
 
 /* ginpostinglist.c */