REASSIGN OWNED: consider grants on tablespaces, too

Apparently this was considered in the original code (see commit
cec3b0a9) but I failed to notice that such entries would always be
skipped by the database check at the start of the loop.

Per bugs #7578 by Nikolay, #6116 by tushar.qa@gmail.com.

diff --git a/src/backend/catalog/pg_shdepend.c b/src/backend/catalog/pg_shdepend.c
index 77e0d08f9b41404a6de80f439fd8cfefc792220b..8d2d37c730a157c241453600075c8a6b3f82a186 100644 (file)
--- a/src/backend/catalog/pg_shdepend.c
+++ b/src/backend/catalog/pg_shdepend.c
@@ -1214,8 +1214,12 @@ shdepDropOwned(List *roleids, DropBehavior behavior)
            Form_pg_shdepend sdepForm = (Form_pg_shdepend) GETSTRUCT(tuple);
            ObjectAddress obj;
 
-           /* We only operate on objects in the current database */
-           if (sdepForm->dbid != MyDatabaseId)
+           /*
+            * We only operate on shared objects and objects in the current
+            * database
+            */
+           if (sdepForm->dbid != MyDatabaseId &&
+               sdepForm->dbid != InvalidOid)
                continue;
 
            switch (sdepForm->deptype)