Assert that syscache lookups don't happen outside transactions.

Andres Freund

diff --git a/src/backend/utils/cache/catcache.c b/src/backend/utils/cache/catcache.c
index d12da7615a1b59147d6a8157230170350a1dc0ed..cca0572a5dc00a87ab7b0aff5cce4400d19af715 100644 (file)
--- a/src/backend/utils/cache/catcache.c
+++ b/src/backend/utils/cache/catcache.c
@@ -21,6 +21,7 @@
 #include "access/sysattr.h"
 #include "access/tuptoaster.h"
 #include "access/valid.h"
+#include "access/xact.h"
 #include "catalog/pg_operator.h"
 #include "catalog/pg_type.h"
 #include "miscadmin.h"
@@ -1067,6 +1068,9 @@ SearchCatCache(CatCache *cache,
    SysScanDesc scandesc;
    HeapTuple   ntp;
 
+   /* Make sure we're in a xact, even if this ends up being a cache hit */
+   Assert(IsTransactionState());
+
    /*
     * one-time startup overhead for each cache
     */