On Darwin, detect and report a multithreaded postmaster.

Darwin --enable-nls builds use a substitute setlocale() that may start a
thread.  Buildfarm member orangutan experienced BackendList corruption
on account of different postmaster threads executing signal handlers
simultaneously.  Furthermore, a multithreaded postmaster risks undefined
behavior from sigprocmask() and fork().  Emit LOG messages about the
problem and its workaround.  Back-patch to 9.0 (all supported versions).

diff --git a/configure b/configure
index fa241d135e0a6d5d411fbf35780dfed6b6836b92..4e52ba4c148db33397fc50db1a2848a361583856 100755 (executable)
--- a/configure
+++ b/configure
@@ -19157,7 +19157,8 @@ LIBS=`echo "$LIBS" | sed -e 's/-ledit//g' -e 's/-lreadline//g'`
 
 
 
-for ac_func in cbrt dlopen fcvt fdatasync getifaddrs getpeerucred getrlimit mbstowcs_l memmove poll pstat readlink scandir setproctitle setsid sigprocmask symlink sysconf towlower utime utimes waitpid wcstombs wcstombs_l
+
+for ac_func in cbrt dlopen fcvt fdatasync getifaddrs getpeerucred getrlimit mbstowcs_l memmove poll pstat pthread_is_threaded_np readlink scandir setproctitle setsid sigprocmask symlink sysconf towlower utime utimes waitpid wcstombs wcstombs_l
 do
 as_ac_var=`$as_echo "ac_cv_func_$ac_func" | $as_tr_sh`
 { $as_echo "$as_me:$LINENO: checking for $ac_func" >&5

diff --git a/configure.in b/configure.in
index 5ebf78352b71a7735e0fd962b325327522bb3fea..f957bb5080c8fa8e969a6adb6ada9d63f2dd5d57 100644 (file)
--- a/configure.in
+++ b/configure.in
@@ -1240,7 +1240,7 @@ PGAC_FUNC_GETTIMEOFDAY_1ARG
 LIBS_including_readline="$LIBS"
 LIBS=`echo "$LIBS" | sed -e 's/-ledit//g' -e 's/-lreadline//g'`
 
-AC_CHECK_FUNCS([cbrt dlopen fcvt fdatasync getifaddrs getpeerucred getrlimit mbstowcs_l memmove poll pstat readlink scandir setproctitle setsid sigprocmask symlink sysconf towlower utime utimes waitpid wcstombs wcstombs_l])
+AC_CHECK_FUNCS([cbrt dlopen fcvt fdatasync getifaddrs getpeerucred getrlimit mbstowcs_l memmove poll pstat pthread_is_threaded_np readlink scandir setproctitle setsid sigprocmask symlink sysconf towlower utime utimes waitpid wcstombs wcstombs_l])
 
 AC_REPLACE_FUNCS(fseeko)
 case $host_os in

diff --git a/src/backend/postmaster/postmaster.c b/src/backend/postmaster/postmaster.c
index 41c4b41a94558be79db63ab58e1d6fef536e86ca..41eb1327a7d56874ff8a4161ba3a87c1e6648592 100644 (file)
--- a/src/backend/postmaster/postmaster.c
+++ b/src/backend/postmaster/postmaster.c
@@ -92,6 +92,10 @@
 #include <dns_sd.h>
 #endif
 
+#ifdef HAVE_PTHREAD_IS_THREADED_NP
+#include <pthread.h>
+#endif
+
 #include "access/transam.h"
 #include "access/xlog.h"
 #include "bootstrap/bootstrap.h"
@@ -1105,6 +1109,24 @@ PostmasterMain(int argc, char *argv[])
     */
    RemovePgTempFiles();
 
+#ifdef HAVE_PTHREAD_IS_THREADED_NP
+
+   /*
+    * On Darwin, libintl replaces setlocale() with a version that calls
+    * CFLocaleCopyCurrent() when its second argument is "" and every relevant
+    * environment variable is unset or empty.  CFLocaleCopyCurrent() makes
+    * the process multithreaded.  The postmaster calls sigprocmask() and
+    * calls fork() without an immediate exec(), both of which have undefined
+    * behavior in a multithreaded program.  A multithreaded postmaster is the
+    * normal case on Windows, which offers neither fork() nor sigprocmask().
+    */
+   if (pthread_is_threaded_np() != 0)
+       ereport(LOG,
+               (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
+                errmsg("postmaster became multithreaded during startup"),
+        errhint("Set the LC_ALL environment variable to a valid locale.")));
+#endif
+
    /*
     * Remember postmaster startup time
     */
@@ -1535,6 +1557,15 @@ ServerLoop(void)
            TouchSocketLockFile();
            last_touch_time = now;
        }
+
+#ifdef HAVE_PTHREAD_IS_THREADED_NP
+
+       /*
+        * With assertions enabled, check regularly for appearance of
+        * additional threads.  All builds check at start and exit.
+        */
+       Assert(pthread_is_threaded_np() == 0);
+#endif
    }
 }
 
@@ -4209,6 +4240,18 @@ SubPostmasterMain(int argc, char *argv[])
 static void
 ExitPostmaster(int status)
 {
+#ifdef HAVE_PTHREAD_IS_THREADED_NP
+
+   /*
+    * There is no known cause for a postmaster to become multithreaded after
+    * startup.  Recheck to account for the possibility of unknown causes.
+    */
+   if (pthread_is_threaded_np() != 0)
+       ereport(LOG,
+               (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
+                errmsg("postmaster became multithreaded")));
+#endif
+
    /* should cleanup shared memory and kill all backends */
 
    /*

diff --git a/src/include/pg_config.h.in b/src/include/pg_config.h.in
index 3ce73698ae955f8029d175f0fdff71f820d5ef5e..c09e0ed021e0011999d842c87ed4bc5d4ed7554e 100644 (file)
--- a/src/include/pg_config.h.in
+++ b/src/include/pg_config.h.in
@@ -393,6 +393,9 @@
 /* Define if you have POSIX threads libraries and header files. */
 #undef HAVE_PTHREAD
 
+/* Define to 1 if you have the `pthread_is_threaded_np' function. */
+#undef HAVE_PTHREAD_IS_THREADED_NP
+
 /* Define to 1 if you have the <pwd.h> header file. */
 #undef HAVE_PWD_H
 

diff --git a/src/port/exec.c b/src/port/exec.c
index cc32077badd94fadc901e0528d63d1ad0e2c7fc3..863ccd230763658511fa4087bc058c9f7d3c7b07 100644 (file)
--- a/src/port/exec.c
+++ b/src/port/exec.c
@@ -570,8 +570,20 @@ set_pglocale_pgservice(const char *argv0, const char *app)
 
    /* don't set LC_ALL in the backend */
    if (strcmp(app, PG_TEXTDOMAIN("postgres")) != 0)
+   {
        setlocale(LC_ALL, "");
 
+       /*
+        * One could make a case for reproducing here PostmasterMain()'s test
+        * for whether the process is multithreaded.  Unlike the postmaster,
+        * no frontend program calls sigprocmask() or otherwise provides for
+        * mutual exclusion between signal handlers.  While frontends using
+        * fork(), if multithreaded, are formally exposed to undefined
+        * behavior, we have not witnessed a concrete bug.  Therefore,
+        * complaining about multithreading here may be mere pedantry.
+        */
+   }
+
    if (find_my_exec(argv0, my_exec_path) < 0)
        return;