Fix typo in PQconnectStartParams().

This would lead to leaking the PGconn structure after an error detected by
conninfo_array_parse(), as well as failing to return a useful error message
in such cases.  Backpatch to 9.0 where the error was introduced.

Joseph Adams

diff --git a/src/interfaces/libpq/fe-connect.c b/src/interfaces/libpq/fe-connect.c
index a4959ee22ec05541c50f40c0f221fd38230605da..aa24c37f9c4b7230f452fe8d6028a60de055dd31 100644 (file)
--- a/src/interfaces/libpq/fe-connect.c
+++ b/src/interfaces/libpq/fe-connect.c
@@ -491,7 +491,7 @@ PQconnectStartParams(const char **keywords,
    {
        conn->status = CONNECTION_BAD;
        /* errorMessage is already set */
-       return false;
+       return conn;
    }
 
    /*