Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Page MenuHomePhabricator

Hovercards: cards display incorrectly for RTL languages
Closed, ResolvedPublic

Description

rtl-broken


Version: unspecified
Severity: major

Attached:

Screen_Shot_2014-03-23_at_12.02.19_pm.png (468×929 px, 147 KB)

Details

Reference
bz62970

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:54 AM
bzimport added a project: Page-Previews.
bzimport set Reference to bz62970.
bzimport added a subscriber: Unknown Object (MLST).

I guess it can be fixed easily by adding @noflip in css

(Reply to Eran on Comment #1)

I guess it can be fixed easily by adding @noflip in css

Mostly that, but certain elements need more work. Will push a fix soon.

Change 122644 had a related patch set uploaded by Prtksxna:
Fix for RTL languages

https://gerrit.wikimedia.org/r/122644

Change 122644 merged by jenkins-bot:
Fix for RTL languages

https://gerrit.wikimedia.org/r/122644

Created attachment 15033
maybe wrong alignment

I have tested it in beta, and it is fixed indeed, though i have one question, in the attached screenshot the card appears to the right of the hovered text and not on the left like the other attachment. why is this happening?

Attached:

why_on_right.png (986×1 px, 82 KB)

Created attachment 15034
correct alignment

Attached:

correct_on_left.png (986×1 px, 80 KB)

(In reply to matanya Comment #6)

I have tested it in beta, and it is fixed indeed, though i
have one question, in the attached screenshot the card appears
to the right of the hovered text and not on the left like the
other attachment. why is this happening?

To avoid the Hovercard appearing off-screen we flip the Hovercard on the right side of the screen.

Prtksxna raised the priority of this task from High to Needs Triage.Dec 3 2014, 5:29 AM
Prtksxna moved this task from Backlog to Archive on the Page-Previews board.