Makefile.m32: add CURL_RC and CURL_STRIP variables [ci skip]
#9132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They allow to override the hardcoded values for the `windres` and `strip`
tools, complementing the existing set of `CURL_{CC,AR,RANLIB}` variables.
`CURL_RC` comes handy when using LLVM tools with `CROSSPREFIX=llvm-` and
`CURL_CC=clang` set on current latest debian:unstable or earlier, where
`llvm-windres` is missing, and a `CURL_RC=<triplet>-windres` fixes it.
Hopefully this will be fixed in the llvm package. FWIW `llvm-windres`
does exist in Homebrew llvm, MSYS2 llvm and llvm-mingw.
b87fbb7
to
0df70f9
Compare
bagder
approved these changes
Jul 10, 2022
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Jul 10, 2022
This requires patching curl's Makefile.m32 buils. PR opened: [1] Fixes regression after 647eb3718782e92c6baa6cf3e9262ff315911b8c and dcb1ea2. [1] curl/curl#9132
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They allow to override the hardcoded values for the
windresandstriptools, complementing the existing set of
CURL_{CC,AR,RANLIB}variables.CURL_RCcomes handy when using LLVM tools withCROSSPREFIX=llvm-andCURL_CC=clangset on current latest debian:unstable or earlier, wherellvm-windresis missing, and aCURL_RC=<triplet>-windresfixes it.Hopefully this will be fixed in the llvm package. FWIW
llvm-windresdoes exist in Homebrew llvm, MSYS2 llvm and llvm-mingw.