Makefile.m32: allow -nghttp3/-ngtcp2 without -ssl [ci skip] #9314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch `-nghttp3`/`-ngtcp2` had an effect only when `-ssl` was also enabled. `-ssl` meaning OpenSSL (and its forks). After 8a13be2 nghttp3/ngtcp2 can also be used together with wolfSSL. This patch adds the ability to enable `-nghttp3`/`-ngtcp2` independently from `-ssl` (OpenSSL), allowing to use it with wolfSSL or other, future TLS backends. Before this patch, it was fine to enable `-nghttp3`/`-ngtcp2` unconditionally. After this patch, this is no longer the case, and now it's the user's responsibility to enable `-nghttp3`/`-ngtcp2` only together with a compatible TLS backend. When using a TLS backend other than OpenSSL, the TLS-specific ngtcp2 library must be configured manually, e.g.: `export CURL_LDFLAG_EXTRAS=-lngtcp2_crypto_wolfssl`
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Aug 15, 2022
…skip] Apply upstream patch: curl/curl@5fd7cd7 curl/curl#9314 This allows to enable nghttp3+ngtcp2 for non-OpenSSL TLS backends. In preparation for wolfSSL HTTP/3 support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch
-nghttp3/-ngtcp2had an effect only when-sslwasalso enabled.
-sslmeaning OpenSSL (and its forks). After8a13be2 nghttp3/ngtcp2 can also be used
together with wolfSSL. This patch adds the ability to enable
-nghttp3/-ngtcp2independently from-ssl(OpenSSL), allowing to useit with wolfSSL or other, future TLS backends.
Before this patch, it was fine to enable
-nghttp3/-ngtcp2unconditionally. After this patch, this is no longer the case, and now
it's the user's responsibility to enable
-nghttp3/-ngtcp2onlytogether with a compatible TLS backend.
When using a TLS backend other than OpenSSL, the TLS-specific ngtcp2
library must be configured manually, e.g.:
export CURL_LDFLAG_EXTRAS=-lngtcp2_crypto_wolfssl