From b669293e3432ee8fdcd44854a945837bb18eea5c Mon Sep 17 00:00:00 2001 From: Daniel Gustafsson Date: Thu, 17 Apr 2025 12:58:00 +0200 Subject: pg_dump: Set private_date pointer to NULL in callback The end callback for ZStandard compression frees the private_data but didn't set the pointer to NULL after freeing. This is not a bug as the code is right now, since nothing is dereferencing the pointer upon returning from the callback but it is good practice to do. Author: Alexander Kuznetsov Reviewed-by: Daniel Gustafsson Reviewed-by: Ashutosh Bapat Reviewed-by: Michael Paquier Reviewed-by: Tom Lane Discussion: https://postgr.es/m/efaee52b-9550-44ca-8633-ea86076b3283@altlinux.org --- src/bin/pg_dump/compress_zstd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/bin/pg_dump/compress_zstd.c b/src/bin/pg_dump/compress_zstd.c index 1f7b4942706..cb595b10c2d 100644 --- a/src/bin/pg_dump/compress_zstd.c +++ b/src/bin/pg_dump/compress_zstd.c @@ -142,6 +142,7 @@ EndCompressorZstd(ArchiveHandle *AH, CompressorState *cs) /* output buffer may be allocated in either mode */ pg_free(zstdcs->output.dst); pg_free(zstdcs); + cs->private_data = NULL; } static void -- cgit v1.2.3