From 7f798aca1d5df290aafad41180baea0ae311b4ee Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Thu, 28 Nov 2024 08:19:22 +0100 Subject: Remove useless casts to (void *) Many of them just seem to have been copied around for no real reason. Their presence causes (small) risks of hiding actual type mismatches or silently discarding qualifiers Discussion: https://www.postgresql.org/message-id/flat/461ea37c-8b58-43b4-9736-52884e862820@eisentraut.org --- src/backend/access/gist/gist.c | 2 +- src/backend/access/gist/gistbuild.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'src/backend/access/gist') diff --git a/src/backend/access/gist/gist.c b/src/backend/access/gist/gist.c index 83b819f1a53..ebc65449c1b 100644 --- a/src/backend/access/gist/gist.c +++ b/src/backend/access/gist/gist.c @@ -173,7 +173,7 @@ gistinsert(Relation r, Datum *values, bool *isnull, oldCxt = MemoryContextSwitchTo(indexInfo->ii_Context); giststate = initGISTstate(r); giststate->tempCxt = createTempGistContext(); - indexInfo->ii_AmCache = (void *) giststate; + indexInfo->ii_AmCache = giststate; MemoryContextSwitchTo(oldCxt); } diff --git a/src/backend/access/gist/gistbuild.c b/src/backend/access/gist/gistbuild.c index ba06df30faf..63d1914b37f 100644 --- a/src/backend/access/gist/gistbuild.c +++ b/src/backend/access/gist/gistbuild.c @@ -273,7 +273,7 @@ gistbuild(Relation heap, Relation index, IndexInfo *indexInfo) /* Scan the table, adding all tuples to the tuplesort */ reltuples = table_index_build_scan(heap, index, indexInfo, true, true, gistSortedBuildCallback, - (void *) &buildstate, NULL); + &buildstate, NULL); /* * Perform the sort and build index pages. @@ -312,7 +312,7 @@ gistbuild(Relation heap, Relation index, IndexInfo *indexInfo) /* Scan the table, inserting all the tuples to the index. */ reltuples = table_index_build_scan(heap, index, indexInfo, true, true, gistBuildCallback, - (void *) &buildstate, NULL); + &buildstate, NULL); /* * If buffering was used, flush out all the tuples that are still in -- cgit v1.2.3