From 8ab6a6b4562efcd9f320353d5438fdbe10dbf9c5 Mon Sep 17 00:00:00 2001
From: Tom Lane
Date: Fri, 3 Sep 2010 01:26:52 +0000
Subject: In HEAD only, revert kluge solution for preventing misuse of
 pg_get_expr().

A data-type-based solution, which is much cleaner and more bulletproof,
will follow shortly.  It seemed best to make this a separate commit though.
---
 src/backend/tcop/fastpath.c | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

(limited to 'src/backend/tcop/fastpath.c')

diff --git a/src/backend/tcop/fastpath.c b/src/backend/tcop/fastpath.c
index 5870081fe30..a5c5a309828 100644
--- a/src/backend/tcop/fastpath.c
+++ b/src/backend/tcop/fastpath.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/tcop/fastpath.c,v 1.105 2010/07/06 19:18:57 momjian Exp $
+ *	  $PostgreSQL: pgsql/src/backend/tcop/fastpath.c,v 1.106 2010/09/03 01:26:52 tgl Exp $
  *
  * NOTES
  *	  This cruft is the server side of PQfn.
@@ -29,7 +29,6 @@
 #include "tcop/fastpath.h"
 #include "tcop/tcopprot.h"
 #include "utils/acl.h"
-#include "utils/fmgroids.h"
 #include "utils/lsyscache.h"
 #include "utils/snapmgr.h"
 #include "utils/syscache.h"
@@ -348,16 +347,6 @@ HandleFunctionRequest(StringInfo msgBuf)
 		aclcheck_error(aclresult, ACL_KIND_PROC,
 					   get_func_name(fid));
 
-	/*
-	 * Restrict access to pg_get_expr(). This reflects the hack in
-	 * transformFuncCall() in parse_expr.c, see comments there for an
-	 * explanation.
-	 */
-	if ((fid == F_PG_GET_EXPR || fid == F_PG_GET_EXPR_EXT) && !superuser())
-		ereport(ERROR,
-				(errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),
-		errmsg("argument to pg_get_expr() must come from system catalogs")));
-
 	/*
 	 * Prepare function call info block and insert arguments.
 	 */
-- 
cgit v1.2.3