From 3dd637f3d5997eb5ef3ccf8787e6fa091d93cd0c Mon Sep 17 00:00:00 2001 From: Alvaro Herrera Date: Wed, 24 Jul 2024 12:38:18 +0200 Subject: Reset relhassubclass upon attaching table as a partition We don't allow inheritance parents as partitions, and have checks to prevent this; but if a table _was_ in the past an inheritance parents and all their children are removed, the pg_class.relhassubclass flag may remain set, which confuses the partition pruning code (most obviously, it results in an assertion failure; in production builds it may be worse.) Fix by resetting relhassubclass on attach. Backpatch to all supported versions. Reported-by: Alexander Lakhin Reviewed-by: Tom Lane Discussion: https://postgr.es/m/18550-d5e047e9a897a889@postgresql.org --- src/backend/catalog/heap.c | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'src/backend') diff --git a/src/backend/catalog/heap.c b/src/backend/catalog/heap.c index 00074c8a948..01b43cc6a84 100644 --- a/src/backend/catalog/heap.c +++ b/src/backend/catalog/heap.c @@ -3520,6 +3520,14 @@ StorePartitionBound(Relation rel, Relation parent, PartitionBoundSpec *bound) new_val, new_null, new_repl); /* Also set the flag */ ((Form_pg_class) GETSTRUCT(newtuple))->relispartition = true; + + /* + * We already checked for no inheritance children, but reset + * relhassubclass in case it was left over. + */ + if (rel->rd_rel->relkind == RELKIND_RELATION && rel->rd_rel->relhassubclass) + ((Form_pg_class) GETSTRUCT(newtuple))->relhassubclass = false; + CatalogTupleUpdate(classRel, &newtuple->t_self, newtuple); heap_freetuple(newtuple); table_close(classRel, RowExclusiveLock); -- cgit v1.2.3