Fix failure to detect some cases of improperly-nested aggregates.

check_agg_arguments_walker() supposed that it needn't descend into
the arguments of a lower-level aggregate function, but this is
just wrong in the presence of multiple levels of sub-select.  The
oversight would lead to executor failures on queries that should
be rejected.  (Prior to v11, they actually were rejected, thanks
to a "redundant" execution-time check.)

Per bug #17835 from Anban Company.  Back-patch to all supported
branches.

Discussion: https://postgr.es/m/17835-4f29f3098b2d0ba4@postgresql.org

diff --git a/src/backend/parser/parse_agg.c b/src/backend/parser/parse_agg.c
index c85af8be611050297261fbb58fd46d08dfbace06..595d7a46b8a3237fccd3b95eaf66a0ae364dce7a 100644 (file)
--- a/src/backend/parser/parse_agg.c
+++ b/src/backend/parser/parse_agg.c
@@ -695,8 +695,7 @@ check_agg_arguments_walker(Node *node,
                context->min_agglevel > agglevelsup)
                context->min_agglevel = agglevelsup;
        }
-       /* no need to examine args of the inner aggregate */
-       return false;
+       /* Continue and descend into subtree */
    }
    if (IsA(node, GroupingFunc))
    {

diff --git a/src/test/regress/expected/aggregates.out b/src/test/regress/expected/aggregates.out
index bacec2216b2f1f6fdae41273de669b46fa676ec8..a0a0895e5fd6a8bfb61cd3029c82193bc35a3a12 100644 (file)
--- a/src/test/regress/expected/aggregates.out
+++ b/src/test/regress/expected/aggregates.out
@@ -954,6 +954,12 @@ select (select max(min(unique1)) from int8_tbl) from tenk1;
 ERROR:  aggregate function calls cannot be nested
 LINE 1: select (select max(min(unique1)) from int8_tbl) from tenk1;
                            ^
+select avg((select avg(a1.col1 order by (select avg(a2.col2) from tenk1 a3))
+            from tenk1 a1(col1)))
+from tenk1 a2(col2);
+ERROR:  aggregate function calls cannot be nested
+LINE 1: select avg((select avg(a1.col1 order by (select avg(a2.col2)...
+                                                        ^
 --
 -- Test removal of redundant GROUP BY columns
 --

diff --git a/src/test/regress/sql/aggregates.sql b/src/test/regress/sql/aggregates.sql
index 4b3583972933accdf72b7adf399693c1abe7186d..93730c689be50c3a68fe50d37a05193874380ceb 100644 (file)
--- a/src/test/regress/sql/aggregates.sql
+++ b/src/test/regress/sql/aggregates.sql
@@ -334,6 +334,9 @@ drop table minmaxtest cascade;
 -- check for correct detection of nested-aggregate errors
 select max(min(unique1)) from tenk1;
 select (select max(min(unique1)) from int8_tbl) from tenk1;
+select avg((select avg(a1.col1 order by (select avg(a2.col2) from tenk1 a3))
+            from tenk1 a1(col1)))
+from tenk1 a2(col2);
 
 --
 -- Test removal of redundant GROUP BY columns