Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Fix incorrectly reported stats kind in "can't happen" ERROR
authorDavid Rowley <drowley@postgresql.org>
Tue, 5 Mar 2024 03:18:42 +0000 (16:18 +1300)
committerDavid Rowley <drowley@postgresql.org>
Tue, 5 Mar 2024 03:18:42 +0000 (16:18 +1300)
The error message(s) were reporting the stats kind of 'f', which is not
correct as that's for the "dependencies" statistics kind.

Reported-by: Horst Reiterer
Reviewed-by: Richard Guo
Discussion: https://postgr.es/m/18375-ba99383eb9062d6a@postgresql.org
Backpatch-through: 12, where MCV extended stats were added.

src/backend/statistics/extended_stats.c
src/backend/statistics/mcv.c

index d28c9d9b81f233f1c89c15a1bbd8a4e6f8322e8c..4212e0cd24915e0096cd153e4e9237bd36fe6dd0 100644 (file)
@@ -2480,7 +2480,7 @@ statext_expressions_load(Oid stxoid, int idx)
    if (isnull)
        elog(ERROR,
             "requested statistics kind \"%c\" is not yet built for statistics object %u",
-            STATS_EXT_DEPENDENCIES, stxoid);
+            STATS_EXT_EXPRESSIONS, stxoid);
 
    eah = DatumGetExpandedArray(value);
 
index 0183775853460b4b123145d319cc5998c4f594ed..e0e9b19c645e4dabad32ca41d5d3119dc986e5e2 100644 (file)
@@ -575,7 +575,7 @@ statext_mcv_load(Oid mvoid)
    if (isnull)
        elog(ERROR,
             "requested statistics kind \"%c\" is not yet built for statistics object %u",
-            STATS_EXT_DEPENDENCIES, mvoid);
+            STATS_EXT_MCV, mvoid);
 
    result = statext_mcv_deserialize(DatumGetByteaP(mcvlist));