Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
postgres_fdw: Fix comments in connection.c.
authorEtsuro Fujita <efujita@postgresql.org>
Thu, 7 Oct 2021 09:15:01 +0000 (18:15 +0900)
committerEtsuro Fujita <efujita@postgresql.org>
Thu, 7 Oct 2021 09:15:01 +0000 (18:15 +0900)
Commit 27e1f1456 missed updating some comments.

Reviewed-by: Bharath Rupireddy
Backpatch-through: 14
Discussion: https://postgr.es/m/CAPmGK15Q2Nm6U%2Ba_GwskrWFEVBZ9_3VKOvRrprGufpx91M_3Sw%40mail.gmail.com

contrib/postgres_fdw/connection.c

index 82aa14a65de42ca6aebdb8e2c8b8f7f0048477b3..ec8b688c5076af689fae3d4c0af9794138722bdb 100644 (file)
@@ -195,9 +195,9 @@ GetConnection(UserMapping *user, bool will_prep_stmt, PgFdwConnState **state)
        make_new_connection(entry, user);
 
    /*
-    * We check the health of the cached connection here when starting a new
-    * remote transaction. If a broken connection is detected, we try to
-    * reestablish a new connection later.
+    * We check the health of the cached connection here when using it.  In
+    * cases where we're out of all transactions, if a broken connection is
+    * detected, we try to reestablish a new connection later.
     */
    PG_TRY();
    {
@@ -213,9 +213,7 @@ GetConnection(UserMapping *user, bool will_prep_stmt, PgFdwConnState **state)
        ErrorData  *errdata = CopyErrorData();
 
        /*
-        * If connection failure is reported when starting a new remote
-        * transaction (not subtransaction), new connection will be
-        * reestablished later.
+        * Determine whether to try to reestablish the connection.
         *
         * After a broken connection is detected in libpq, any error other
         * than connection failure (e.g., out-of-memory) can be thrown