Remove unnecessary clauses_attnums variable

Commit c676e659b2 reworked how choose_best_statistics() picks the best
extended statistics, but failed to remove clauses_attnums which is now
unnecessary. So get rid of it and backpatch to 12, same as c676e659b2.

Author: Tomas Vondra
Discussion: https://postgr.es/m/CA+u7OA7H5rcE2=8f263w4NZD6ipO_XOrYB816nuLXbmSTH9pQQ@mail.gmail.com
Backpatch-through: 12

diff --git a/src/backend/statistics/extended_stats.c b/src/backend/statistics/extended_stats.c
index ca6d5c34e36d266a8f6dce6c9afe701fd016df6d..4516c97f4066ac5cd87ae8b43b46b68791e77fc4 100644 (file)
--- a/src/backend/statistics/extended_stats.c
+++ b/src/backend/statistics/extended_stats.c
@@ -1059,7 +1059,6 @@ statext_mcv_clauselist_selectivity(PlannerInfo *root, List *clauses, int varReli
                                   RelOptInfo *rel, Bitmapset **estimatedclauses)
 {
    ListCell   *l;
-   Bitmapset  *clauses_attnums = NULL;
    Bitmapset **list_attnums;
    int         listidx;
    StatisticExtInfo *stat;
@@ -1097,10 +1096,7 @@ statext_mcv_clauselist_selectivity(PlannerInfo *root, List *clauses, int varReli
 
        if (!bms_is_member(listidx, *estimatedclauses) &&
            statext_is_compatible_clause(root, clause, rel->relid, &attnums))
-       {
            list_attnums[listidx] = attnums;
-           clauses_attnums = bms_add_members(clauses_attnums, attnums);
-       }
        else
            list_attnums[listidx] = NULL;