PL/Perl portability fix: absorb relevant -D switches from Perl.

Back-patch of commit 3c163a7fc76debbbdad1bdd3c43721cffe72f4db,
which see for more info.

Also throw in commit b4cc35fbb709bd6fcae8998f041fd731c9acbf42,
so Coverity doesn't whine about the back branches.

Ashutosh Sharma, some adjustments by me

Discussion: https://postgr.es/m/CANFyU97OVQ3+Mzfmt3MhuUm5NwPU=-FtbNH5Eb7nZL9ua8=rcA@mail.gmail.com

diff --git a/config/perl.m4 b/config/perl.m4
index bed2eae57fe21af61dd764408ae3c038eee7fa16..9706c4de6aca951b9187c0b3f689faf581084ddf 100644 (file)
--- a/config/perl.m4
+++ b/config/perl.m4
@@ -49,6 +49,31 @@ AC_DEFUN([PGAC_CHECK_PERL_CONFIGS],
 [m4_foreach([pgac_item], [$1], [PGAC_CHECK_PERL_CONFIG(pgac_item)])])
 
 
+# PGAC_CHECK_PERL_EMBED_CCFLAGS
+# -----------------------------
+# We selectively extract stuff from $Config{ccflags}.  We don't really need
+# anything except -D switches, and other sorts of compiler switches can
+# actively break things if Perl was compiled with a different compiler.
+# Moreover, although Perl likes to put stuff like -D_LARGEFILE_SOURCE and
+# -D_FILE_OFFSET_BITS=64 here, it would be fatal to try to compile PL/Perl
+# to a different libc ABI than core Postgres uses.  The available information
+# says that all the symbols that affect Perl's own ABI begin with letters,
+# so it should be sufficient to adopt -D switches for symbols not beginning
+# with underscore.
+# For debugging purposes, let's have the configure output report the raw
+# ccflags value as well as the set of flags we chose to adopt.
+AC_DEFUN([PGAC_CHECK_PERL_EMBED_CCFLAGS],
+[AC_REQUIRE([PGAC_PATH_PERL])
+AC_MSG_CHECKING([for CFLAGS recommended by Perl])
+perl_ccflags=`$PERL -MConfig -e ['print $Config{ccflags}']`
+AC_MSG_RESULT([$perl_ccflags])
+AC_MSG_CHECKING([for CFLAGS to compile embedded Perl])
+perl_embed_ccflags=`$PERL -MConfig -e ['foreach $f (split(" ",$Config{ccflags})) {print $f, " " if ($f =~ /^-D[^_]/)}']`
+AC_SUBST(perl_embed_ccflags)dnl
+AC_MSG_RESULT([$perl_embed_ccflags])
+])# PGAC_CHECK_PERL_EMBED_CCFLAGS
+
+
 # PGAC_CHECK_PERL_EMBED_LDFLAGS
 # -----------------------------
 # We are after Embed's ldopts, but without the subset mentioned in

diff --git a/configure b/configure
index 53199f6a349ab7e31892bbb9756eab06d61e437a..d9221e0d5f605c17338ab02f1a3a49057f71c130 100755 (executable)
--- a/configure
+++ b/configure
@@ -669,6 +669,7 @@ python_version
 python_majorversion
 PYTHON
 perl_embed_ldflags
+perl_embed_ccflags
 perl_useshrplib
 perl_privlibexp
 perl_archlibexp
@@ -7390,6 +7391,18 @@ test "$PORTNAME" = "win32" && perl_useshrplib=`echo $perl_useshrplib | sed 's,\\
 { $as_echo "$as_me:${as_lineno-$LINENO}: result: $perl_useshrplib" >&5
 $as_echo "$perl_useshrplib" >&6; }
 
+{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for CFLAGS recommended by Perl" >&5
+$as_echo_n "checking for CFLAGS recommended by Perl... " >&6; }
+perl_ccflags=`$PERL -MConfig -e 'print $Config{ccflags}'`
+{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $perl_ccflags" >&5
+$as_echo "$perl_ccflags" >&6; }
+{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for CFLAGS to compile embedded Perl" >&5
+$as_echo_n "checking for CFLAGS to compile embedded Perl... " >&6; }
+perl_embed_ccflags=`$PERL -MConfig -e 'foreach $f (split(" ",$Config{ccflags})) {print $f, " " if ($f =~ /^-D[^_]/)}'`
+{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $perl_embed_ccflags" >&5
+$as_echo "$perl_embed_ccflags" >&6; }
+
+
 { $as_echo "$as_me:${as_lineno-$LINENO}: checking for flags to link embedded Perl" >&5
 $as_echo_n "checking for flags to link embedded Perl... " >&6; }
 if test "$PORTNAME" = "win32" ; then

diff --git a/configure.in b/configure.in
index 7a1406c24785076fa2e7d40dad503e6319480dc1..ba780af3abc4c1c22e1a302c3ce11e5f4f98a636 100644 (file)
--- a/configure.in
+++ b/configure.in
@@ -885,6 +885,7 @@ if test "$with_perl" = yes; then
     AC_MSG_ERROR([Perl not found])
   fi
   PGAC_CHECK_PERL_CONFIGS([archlibexp,privlibexp,useshrplib])
+  PGAC_CHECK_PERL_EMBED_CCFLAGS
   PGAC_CHECK_PERL_EMBED_LDFLAGS
 fi
 

diff --git a/src/Makefile.global.in b/src/Makefile.global.in
index b4c38e2f82dab423fcca7cab620885e0482d289e..e92b395376bef7ec060564314c1396e2f9d5dee8 100644 (file)
--- a/src/Makefile.global.in
+++ b/src/Makefile.global.in
@@ -298,6 +298,7 @@ endif
 perl_archlibexp        = @perl_archlibexp@
 perl_privlibexp        = @perl_privlibexp@
 perl_useshrplib        = @perl_useshrplib@
+perl_embed_ccflags = @perl_embed_ccflags@
 perl_embed_ldflags = @perl_embed_ldflags@
 
 # Miscellaneous

diff --git a/src/pl/plperl/GNUmakefile b/src/pl/plperl/GNUmakefile
index 1e800a344c834a0fa24554305a70febb1204ad44..993b8f65558ec245d26b9762e145b7ba684bf4ae 100644 (file)
--- a/src/pl/plperl/GNUmakefile
+++ b/src/pl/plperl/GNUmakefile
@@ -22,7 +22,11 @@ override CPPFLAGS += -DPLPERL_HAVE_UID_GID
 override CFLAGS += -Wno-comment
 endif
 
-override CPPFLAGS := -I. -I$(srcdir) $(CPPFLAGS) -I$(perl_archlibexp)/CORE
+# Note: we need to make sure that the CORE directory is included last,
+# probably because it sometimes contains some header files with names
+# that clash with some of ours, or with some that we include, notably on
+# Windows.
+override CPPFLAGS := -I. -I$(srcdir) $(CPPFLAGS) $(perl_embed_ccflags) -I$(perl_archlibexp)/CORE
 
 rpathdir = $(perl_archlibexp)/CORE
 

diff --git a/src/pl/plperl/plperl.c b/src/pl/plperl/plperl.c
index ca85eb93afdd1b9ee575e10cfd30077442638fc9..56d117bc96e21323d92dd8dd295e2f9d22825653 100644 (file)
--- a/src/pl/plperl/plperl.c
+++ b/src/pl/plperl/plperl.c
@@ -3176,12 +3176,18 @@ plperl_return_next_internal(SV *sv)
 
        /*
         * This is the first call to return_next in the current PL/Perl
-        * function call, so memoize some lookups
+        * function call, so identify the output tuple descriptor and create a
+        * tuplestore to hold the result rows.
         */
        if (prodesc->fn_retistuple)
            (void) get_call_result_type(fcinfo, NULL, &tupdesc);
        else
+       {
            tupdesc = rsi->expectedDesc;
+           /* Protect assumption below that we return exactly one column */
+           if (tupdesc == NULL || tupdesc->natts != 1)
+               elog(ERROR, "expected single-column result descriptor for non-composite SETOF result");
+       }
 
        /*
         * Make sure the tuple_store and ret_tdesc are sufficiently
@@ -3231,20 +3237,20 @@ plperl_return_next_internal(SV *sv)
    }
    else
    {
-       Datum       ret;
-       bool        isNull;
+       Datum       ret[1];
+       bool        isNull[1];
 
-       ret = plperl_sv_to_datum(sv,
-                                prodesc->result_oid,
-                                -1,
-                                fcinfo,
-                                &prodesc->result_in_func,
-                                prodesc->result_typioparam,
-                                &isNull);
+       ret[0] = plperl_sv_to_datum(sv,
+                                   prodesc->result_oid,
+                                   -1,
+                                   fcinfo,
+                                   &prodesc->result_in_func,
+                                   prodesc->result_typioparam,
+                                   &isNull[0]);
 
        tuplestore_putvalues(current_call_data->tuple_store,
                             current_call_data->ret_tdesc,
-                            &ret, &isNull);
+                            ret, isNull);
    }
 
    MemoryContextSwitchTo(old_cxt);

diff --git a/src/tools/msvc/Mkvcbuild.pm b/src/tools/msvc/Mkvcbuild.pm
index ca317df98e5be0e94687b25c4c699fd4a5e39de7..d7b64a4046eba9ec0db5466a31841ede61ae4dbb 100644 (file)
--- a/src/tools/msvc/Mkvcbuild.pm
+++ b/src/tools/msvc/Mkvcbuild.pm
@@ -140,7 +140,26 @@ sub mkvcbuild
        my $plperl =
          $solution->AddProject('plperl', 'dll', 'PLs', 'src\pl\plperl');
        $plperl->AddIncludeDir($solution->{options}->{perl} . '/lib/CORE');
-       $plperl->AddDefine('PLPERL_HAVE_UID_GID');
+
+       # Add defines from Perl's ccflags; see PGAC_CHECK_PERL_EMBED_CCFLAGS
+       my @perl_embed_ccflags;
+       foreach my $f (split(" ",$Config{ccflags}))
+       {
+           if ($f =~ /^-D[^_]/)
+           {
+               $f =~ s/\-D//;
+               push(@perl_embed_ccflags, $f);
+           }
+       }
+
+       # XXX this probably is redundant now?
+       push(@perl_embed_ccflags, 'PLPERL_HAVE_UID_GID');
+
+       foreach my $f (@perl_embed_ccflags)
+       {
+           $plperl->AddDefine($f);
+       }
+
        foreach my $xs ('SPI.xs', 'Util.xs')
        {
            (my $xsc = $xs) =~ s/\.xs/.c/;