Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Fix incorrectly reported stats kind in "can't happen" ERROR
authorDavid Rowley <drowley@postgresql.org>
Tue, 5 Mar 2024 03:17:53 +0000 (16:17 +1300)
committerDavid Rowley <drowley@postgresql.org>
Tue, 5 Mar 2024 03:17:53 +0000 (16:17 +1300)
The error message(s) were reporting the stats kind of 'f', which is not
correct as that's for the "dependencies" statistics kind.

Reported-by: Horst Reiterer
Reviewed-by: Richard Guo
Discussion: https://postgr.es/m/18375-ba99383eb9062d6a@postgresql.org
Backpatch-through: 12, where MCV extended stats were added.

src/backend/statistics/extended_stats.c
src/backend/statistics/mcv.c

index 28b52d8aa1f88f9087cbe3617e7a57f74bf30cb2..547d4b77be8a664ff1d5e83f66ab5f73a1f8c045 100644 (file)
@@ -2467,7 +2467,7 @@ statext_expressions_load(Oid stxoid, bool inh, int idx)
    if (isnull)
        elog(ERROR,
             "requested statistics kind \"%c\" is not yet built for statistics object %u",
-            STATS_EXT_DEPENDENCIES, stxoid);
+            STATS_EXT_EXPRESSIONS, stxoid);
 
    eah = DatumGetExpandedArray(value);
 
index 03b9f04bb560c6b80e846eaa9414d55cc0556b7b..627bc81c58f29b162fb2242fbb0a8b34e43fe5ab 100644 (file)
@@ -576,7 +576,7 @@ statext_mcv_load(Oid mvoid, bool inh)
    if (isnull)
        elog(ERROR,
             "requested statistics kind \"%c\" is not yet built for statistics object %u",
-            STATS_EXT_DEPENDENCIES, mvoid);
+            STATS_EXT_MCV, mvoid);
 
    result = statext_mcv_deserialize(DatumGetByteaP(mcvlist));