Check for stack overrun in standard_ProcessUtility().

ProcessUtility can recurse, and indeed can be driven to infinite
recursion, so it ought to have a check_stack_depth() call.  This
covers the reported bug (portal trying to execute itself) and a bunch
of other cases that could perhaps arise somewhere.

Per bug #15428 from Malthe Borch.  Back-patch to all supported branches.

Discussion: https://postgr.es/m/15428-b3c2915ec470b033@postgresql.org

diff --git a/src/backend/tcop/utility.c b/src/backend/tcop/utility.c
index b5804f64ad46cbb95991dfbfaf572e4ae4bc34b4..ad3a68a79b7ea7596c5790548eaedba9ffe3ec71 100644 (file)
--- a/src/backend/tcop/utility.c
+++ b/src/backend/tcop/utility.c
@@ -387,6 +387,9 @@ standard_ProcessUtility(PlannedStmt *pstmt,
    bool        isAtomicContext = (!(context == PROCESS_UTILITY_TOPLEVEL || context == PROCESS_UTILITY_QUERY_NONATOMIC) || IsTransactionBlock());
    ParseState *pstate;
 
+   /* This can recurse, so check for excessive recursion */
+   check_stack_depth();
+
    check_xact_readonly(parsetree);
 
    if (completionTag)