Remove redundant incomplete split assertion.

The fastpath insert optimization's incomplete split flag Assert() is
redundant.  We'll reach the more general Assert() within
_bt_findinsertloc() in all cases. (Besides, Assert()'ing that the
rightmost page doesn't have the flag set never made much sense.)

diff --git a/src/backend/access/nbtree/nbtinsert.c b/src/backend/access/nbtree/nbtinsert.c
index 144d339e8d4953649ffbfde78bce69237759aafb..7ddba3ff9ff2a17dcc41e766d6da6ed012c80a6a 100644 (file)
--- a/src/backend/access/nbtree/nbtinsert.c
+++ b/src/backend/access/nbtree/nbtinsert.c
@@ -179,11 +179,6 @@ top:
                PageGetMaxOffsetNumber(page) >= P_FIRSTDATAKEY(lpageop) &&
                _bt_compare(rel, itup_key, page, P_FIRSTDATAKEY(lpageop)) > 0)
            {
-               /*
-                * The right-most block should never have an incomplete split.
-                * But be paranoid and check for it anyway.
-                */
-               Assert(!P_INCOMPLETE_SPLIT(lpageop));
                fastpath = true;
            }
            else