FEAT - Adding optional kwargs to huggingface chat target #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 11, 2024 15:36
romanlutz
reviewed
Dec 12, 2024
romanlutz
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This feature adds the optional keywords
device_map,torch_dtype, andattn_implementationto theHuggingFaceChatTargetclass. This PR addresses the Issue #601 I recently opened. I often have to specify these parameters when loading intermediate development models of thePhifamily, as well as other open source models from Huggingface of similar size.Tests and Documentation
I added a test to check whether optional arguments are loaded correctly when loading a HuggingFace model. I have also successfully ran this code in my local branch.
Hi haven't run JupyText yet.