T110728: Trim trailing newlines from DecimalValues #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $a = $this->getValue(); | ||
| $b = $that->getValue(); | ||
| $a = $this->value; | ||
| $b = $that->value; |
There was a problem hiding this comment.
this kind of "btw" change makes review harder for me.
There was a problem hiding this comment.
I worked extra hard to minimize the diff to an absolute minimum. I could have uploaded these 3 lines as a separate patch, and do this most of the time, but found its not worth it in this case.
There was a problem hiding this comment.
Why polluting the stack trace to access a property?
|
Seems fine overall, though I don't like the "marginal" changes much. |
| @@ -40,46 +40,38 @@ class DecimalValue extends DataValueObject { | |||
| * Regular expression for matching decimal strings that conform to the format | |||
| * described in the class level documentation of @see DecimalValue. | |||
| */ | |||
| const QUANTITY_VALUE_PATTERN = '/^[-+]([1-9]\d*|\d)(\.\d+)?$/'; | |||
| const QUANTITY_VALUE_PATTERN = '/^[-+]([1-9]\d*|\d)(\.\d+)?\z/'; | |||
There was a problem hiding this comment.
/^-+(.\d+)?$/D should also work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make bogus QuantityValues in the database magically disappear over time, every time an entity is edited. The newlines will also immediately disappear from all exports.
Bug: T110728