-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize time metadata #2052
base: b4b-dev
Are you sure you want to change the base?
Conversation
Also renamed related dimid variable.
Also update Externals.cfg to use RTM and MOSART versions that have this same change.
Marked as blocked:dependency because, at the moment, |
Enable prescribed crop calendars This branch enables CLM to read in externally-prescribed crop sowing dates and "cultivar" maturity requirements (growing degree-days, GDDs). This has so far only been tested with static values, and the results indicate that yield performance is worsened. However, this capability is required by the GGCMI phase 3 / ISIMIP3 Agriculture protocol. Briefly, the way this works is that an offline run is first performed with prescribed sowing dates and 364-day seasons. Instantaneous GDD accumulation is saved daily. A Python script then cross-references those daily outputs with a map of mean sowing dates to determine the mean accumulated GDDs in the growing season, saving the result as a file for use as prescribed maturity requirements.
From CTSM software engineering meeting today: This doesn't need to wait on other time-related PRs. It can come in as soon as the relevant externals are updated (and Externals.cfg here is changed to point to them). |
Description of changes
Standardizes a dimension name of output variable
time_bounds
(fromhist_interval
tonbnd
), as well as attributes for that plusmcdate
,mcsec
,mdcur
, andmscur
.Specific notes
Contributors other than yourself: @billsacks, @ekluzek
CTSM Issues Fixed: Resolves #1693.
Are answers expected to change (and if so in what way)? No.
Any User Interface Changes (namelist or namelist defaults changes)? No.
Testing performed
New metadata in a history file from a short test:
All
aux_clm
tests pass bit-for-bit againstctsm5.1.dev131
, except for expected failures.