Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordering of cells in CubicalComplex #318

Open
mglisse opened this issue May 17, 2020 · 0 comments
Open

Ordering of cells in CubicalComplex #318

mglisse opened this issue May 17, 2020 · 0 comments

Comments

@mglisse
Copy link
Member

mglisse commented May 17, 2020

@MathieuCarriere 's new function cofaces_of_persistence_pairs returns an index into a flattened version of the array of top dimensional cells. While the constructor taking a numpy array had somehow hidden the unintuitive ordering of the cells, this exposes it again.
We need to add some description of the order. When adding the constructor from numpy array, we had a choice between 2 versions (IIRC: fortran order, or reverse the dimensions) and picked one randomly because it didn't matter. Well, now it matters again, so we need to decide which one we want.
We could also provide the output in a different form (with some option?). numpy.nonzero for instance does not return an array of indices into a flattened array, it returns d arrays corresponding to the indices in the d-dimensional array. This form of output has the advantage that it does not depend on the internal ordering, and it is ready for indexing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant