Add span_id to LogEntry#5885
Merged
tseaver merged 2 commits intogoogleapis:masterfrom Sep 4, 2018
salrashid123:add-logging-span-option
Merged
Add span_id to LogEntry#5885tseaver merged 2 commits intogoogleapis:masterfrom salrashid123:add-logging-span-option
tseaver merged 2 commits intogoogleapis:masterfrom
salrashid123:add-logging-span-option
Conversation
tseaver
approved these changes
Sep 4, 2018
Contributor
Author
|
am i missing something in the cover tests? i didn't really do anything there to account for that coverage failure |
Contributor
|
@salrashid123 I'm puzzled, too: that branch / line should be covered by |
Contributor
Author
|
@tseaver Is there a directive you can invoke to rerun the checks (i.e, btw, i tried running i tried changing the |
Contributor
|
Nice catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
span_idtoLogEntryNote
traceshould get specified ifspan_idis set. The logging API does not currently return an error and while the final displayed log line does have aspan_id, its not too useful. Instead of client-side validation, CloudLogging would return exception later (i'll file internal FR for that)ref: