Add trace and span_id to logging async API#5908
Conversation
|
Do I need to add any tests for these changes? If so, may someone please guide me to where such files are? |
but Am I seeing things wrong? |
logging/google/cloud/logging/handlers/transports/background_thread.py
Outdated
Show resolved
Hide resolved
logging/google/cloud/logging/handlers/transports/background_thread.py
Outdated
Show resolved
Hide resolved
logging/google/cloud/logging/handlers/transports/background_thread.py
Outdated
Show resolved
Hide resolved
logging/google/cloud/logging/handlers/transports/background_thread.py
Outdated
Show resolved
Hide resolved
logging/google/cloud/logging/handlers/transports/background_thread.py
Outdated
Show resolved
Hide resolved
logging/google/cloud/logging/handlers/transports/background_thread.py
Outdated
Show resolved
Hide resolved
logging/tests/unit/handlers/transports/test_background_thread.py
Outdated
Show resolved
Hide resolved
logging/tests/unit/handlers/transports/test_background_thread.py
Outdated
Show resolved
Hide resolved
logging/tests/unit/handlers/transports/test_background_thread.py
Outdated
Show resolved
Hide resolved
logging/tests/unit/handlers/transports/test_background_thread.py
Outdated
Show resolved
Hide resolved
... by tseaver
... and made related similar lines look similar
a35aa40 to
b1af8fa
Compare
|
@tseaver please re-review. |
|
@brunoais I'm pretty sure we have a new feature release scheduled for the first week in October. We could make another before then (without that pending feature) if @snehashah16 wants us to. |
|
OK! Thank you! |
|
@brunoais Oops, I crossed my wires in that response: @snehashah16 is responsible for spanner, not logging. I think @liyanhui1228 is the logging person. |
|
Got it. Thanks for both m8! |
Follow up to #5885 and #5878. Add function parameters on the logging async API to allow API logging with trace and span_id in a non-blocking way.