fixes eslint errors.

Signed-off-by: Eric Wang <skygragon@gmail.com>

Author: skygragon

.eslintrc.js

@@ -1,17 +1,36 @@
 module.exports = {
     "env": {
       "browser": false,
-      "node": true,
-      "es6": true
+      "es6": true,
+      "mocha": true,
+      "node": true
     },
-    "extends": "google",
+    "extends": [
+      "google",
+      "eslint:recommended"
+    ],
     "rules": {
+      "block-spacing": [2, "always"],
+      "brace-style": [2, "1tbs", { "allowSingleLine": true }],
+      "camelcase": [2, {properties: "never"}],
       "comma-dangle": 0,
       "curly": 0,
       "key-spacing": [2, {align: "value"}],
-      "max-len": [1, 120],
+      "max-len": [1, 150],
+      "no-console": 1,
+      "no-empty": [2, { "allowEmptyCatch": true }],
+      "no-eval": 1, // we use it on purpose
+      "no-loop-func": 1,
+      "no-multi-spaces": 0,
+      "no-proto": 1,
+      "no-unused-expressions": 1,
+      "no-unused-vars": 1,
       "no-var": 0,
+      "no-warning-comments": 0,
+      "prefer-rest-params": 0,
+      "prefer-spread": 0,
+      "quote-props": 1,
       "quotes": [2, "single", {avoidEscape: true}],
-      "require-jsdoc": 0
+      "require-jsdoc": 0,
     }
 };

package.json

@@ -23,7 +23,7 @@
   },
   "homepage": "https://github.com/skygragon/leetcode-cli-plugins#readme",
   "devDependencies": {
-    "eslint": "^4.4.1",
-    "eslint-config-google": "^0.9.1"
+    "eslint": "5.9.0",
+    "eslint-config-google": "0.11.0"
   }
 }

plugins/company.js

@@ -21,6 +21,7 @@ var COMPONIES = {
   '5': ['amazon', 'bloomberg', 'microsoft'],
   '7': ['apple', 'bloomberg'],
   '8': ['amazon', 'bloomberg', 'microsoft', 'uber'],
+
   '10': ['airbnb', 'facebook', 'google', 'twitter', 'uber'],
   '11': ['bloomberg'],
   '12': ['twitter'],
@@ -84,6 +85,7 @@ var COMPONIES = {
   '94': ['microsoft'],
   '96': ['snapchat'],
   '98': ['amazon', 'bloomberg', 'facebook', 'microsoft'],
+
   '100': ['bloomberg'],
   '101': ['bloomberg', 'linkedin', 'microsoft'],
   '102': ['amazon', 'apple', 'bloomberg', 'facebook', 'linkedin', 'microsoft'],
@@ -532,6 +534,7 @@ var TAGS = {
   '7': ['math'],
   '8': ['math', 'string'],
   '9': ['math'],
+
   '10': ['backtracking', 'dynamic-programming', 'string'],
   '11': ['array', 'two-pointers'],
   '12': ['math', 'string'],
@@ -622,6 +625,7 @@ var TAGS = {
   '97': ['dynamic-programming', 'string'],
   '98': ['depth-first-search', 'tree'],
   '99': ['depth-first-search', 'tree'],
+
   '100': ['depth-first-search', 'tree'],
   '101': ['breadth-first-search', 'depth-first-search', 'tree'],
   '102': ['breadth-first-search', 'tree'],

plugins/cookie.chrome.js

@@ -28,7 +28,7 @@ plugin.help = function() {
 var Chrome = {};
 
 var ChromeMAC = {
-  getDBPath:   function() {
+  getDBPath: function() {
     return `${process.env.HOME}/Library/Application Support/Google/Chrome/${this.profile}/Cookies`;
   },
   iterations:  1003,
@@ -39,7 +39,7 @@ var ChromeMAC = {
 };
 
 var ChromeLinux = {
-  getDBPath:   function() {
+  getDBPath: function() {
     return `${process.env.HOME}/.config/google-chrome/${this.profile}/Cookies`;
   },
   iterations:  1,
@@ -52,7 +52,7 @@ var ChromeLinux = {
 };
 
 var ChromeWindows = {
-  getDBPath:   function() {
+  getDBPath: function() {
     return path.resolve(process.env.APPDATA || '', `../Local/Google/Chrome/User Data/${this.profile}/Cookies`);
   },
   getPassword: function(cb) { cb(); }

plugins/cookie.firefox.js

@@ -48,7 +48,7 @@ function getCookies(cb) {
       });
     });
   });
-};
+}
 
 plugin.signin = function(user, cb) {
   log.debug('running cookie.firefox.signin');

plugins/lintcode.js

@@ -218,9 +218,9 @@ function runCode(problem, isTest, cb) {
   const opts = makeOpts(config.sys.urls.test);
   opts.headers.referer = problem.link;
   opts.form = {
-    problem_id:          problem.id,
-    code:                file.data(problem.file),
-    language:            lang.text
+    problem_id: problem.id,
+    code:       file.data(problem.file),
+    language:   lang.text
   };
   if (isTest) {
     opts.form.input = problem.testcase;
@@ -330,8 +330,8 @@ plugin.login = function(user, cb) {
       'x-csrftoken': null
     },
     form: {
-      username_or_email:   user.login,
-      password:            user.pass
+      username_or_email: user.login,
+      password:          user.pass
     }
   };
 

plugins/solution.discuss.js

@@ -1,5 +1,4 @@
 var _ = require('underscore');
-var cheerio = require('cheerio');
 var request = require('request');
 
 var log = require('../log');
@@ -24,7 +23,7 @@ function getSolution(problem, lang, cb) {
   var opts = {
     url:  URL_DISCUSSES,
     json: true,
-    qs: {
+    qs:   {
       query: [
         'query fetchTopics($questionId: Int!, $pageNo: Int!, $orderBy: String!) {',
         '  questionTopics(questionId: $questionId, pageNo: $pageNo, orderBy: $orderBy) {',
@@ -42,8 +41,9 @@ function getSolution(problem, lang, cb) {
         '  }',
         '}'
       ].join('\n'),
+
       operationName: 'fetchTopics',
-      variables: JSON.stringify({
+      variables:     JSON.stringify({
         pageNo:     1,
         orderBy:    'most_votes',
         questionId: problem.id