From 56f0ceffd0d43345b75ad41fd7c6f119e07722be Mon Sep 17 00:00:00 2001 From: "sheche@microsoft.com" Date: Sun, 17 Mar 2019 19:26:04 +0800 Subject: [PATCH 1/2] Update the title when changing the problem --- src/leetCodePreviewProvider.ts | 5 ++--- src/leetCodeResultProvider.ts | 2 +- src/leetCodeSolutionProvider.ts | 2 +- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/leetCodePreviewProvider.ts b/src/leetCodePreviewProvider.ts index 5d418a8f..5ee37f7d 100644 --- a/src/leetCodePreviewProvider.ts +++ b/src/leetCodePreviewProvider.ts @@ -12,9 +12,7 @@ class LeetCodePreviewProvider implements Disposable { public async preview(node: IProblem): Promise { if (!this.panel) { - const panelType: string = "previewProblem"; - const panelTitle: string = node.name; - this.panel = window.createWebviewPanel(panelType, panelTitle, ViewColumn.Active, { + this.panel = window.createWebviewPanel("leetcode.preview", "Preview Problem", ViewColumn.Active, { enableScripts: true, enableCommandUris: true, enableFindWidget: true, @@ -35,6 +33,7 @@ class LeetCodePreviewProvider implements Disposable { } }); this.panel.webview.html = await this.provideHtmlContent(node); + this.panel.title = node.name; } public dispose(): void { diff --git a/src/leetCodeResultProvider.ts b/src/leetCodeResultProvider.ts index 0a0a2ce4..189eed17 100644 --- a/src/leetCodeResultProvider.ts +++ b/src/leetCodeResultProvider.ts @@ -14,7 +14,7 @@ class LeetCodeResultProvider implements Disposable { public async show(result: string): Promise { if (!this.panel) { - this.panel = window.createWebviewPanel("leetCode", "LeetCode Results", ViewColumn.Two, { + this.panel = window.createWebviewPanel("leetcode.result", "LeetCode Results", ViewColumn.Two, { retainContextWhenHidden: true, enableFindWidget: true, }); diff --git a/src/leetCodeSolutionProvider.ts b/src/leetCodeSolutionProvider.ts index afbf88d6..ddf32163 100644 --- a/src/leetCodeSolutionProvider.ts +++ b/src/leetCodeSolutionProvider.ts @@ -40,7 +40,7 @@ class LeetCodeSolutionProvider implements Disposable { public async show(solutionString: string, problem: IProblem): Promise { if (!this.panel) { - this.panel = window.createWebviewPanel("leetCode", "Top voted solution", ViewColumn.Active, { + this.panel = window.createWebviewPanel("leetCode.solution", "Top Voted Solution", ViewColumn.Active, { retainContextWhenHidden: true, enableFindWidget: true, localResourceRoots: [vscode.Uri.file(path.join(this.markdownPath, "media"))], From 4c5c15ed24ae7caba5d58993dba74fd836bc4d24 Mon Sep 17 00:00:00 2001 From: "sheche@microsoft.com" Date: Sun, 17 Mar 2019 19:46:44 +0800 Subject: [PATCH 2/2] Reveal the preview panel --- src/leetCodePreviewProvider.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/leetCodePreviewProvider.ts b/src/leetCodePreviewProvider.ts index 5ee37f7d..0b1b30dc 100644 --- a/src/leetCodePreviewProvider.ts +++ b/src/leetCodePreviewProvider.ts @@ -34,6 +34,7 @@ class LeetCodePreviewProvider implements Disposable { }); this.panel.webview.html = await this.provideHtmlContent(node); this.panel.title = node.name; + this.panel.reveal(); } public dispose(): void {