Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 1eed3d3

Browse files
committed
Added some comments on code improvement
1 parent c231dd7 commit 1eed3d3

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/main/java/com/rampatra/arrays/searching/BinarySearch.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ private static int binarySearch(int[] a, int n) {
2424
public static int binarySearch(int[] a, int n, int low, int high) {
2525

2626
if (low <= high) {
27-
int mid = (low + high) / 2;
27+
int mid = (low + high) / 2; // to prevent overflow you can instead do: mid = low + (high - low) / 2
2828

2929
if (n == a[mid]) {
3030
return mid;
@@ -48,7 +48,7 @@ public static int binarySearch(int[] a, int n, int low, int high) {
4848
private static int binarySearchNonRecursive(int[] a, int n) {
4949
int low = 0, high = a.length, mid;
5050
while (low <= high) {
51-
mid = (low + high) / 2;
51+
mid = (low + high) / 2; // to prevent overflow you can instead do: mid = low + (high - low) / 2
5252
if (n == a[mid]) {
5353
return mid;
5454
} else if (n < a[mid]) {

0 commit comments

Comments
 (0)