Remove Subscription Wrapper from Observable.subscribe#1243
Merged
benjchristensen merged 2 commits intoReactiveX:masterfrom May 22, 2014
Merged
Remove Subscription Wrapper from Observable.subscribe#1243benjchristensen merged 2 commits intoReactiveX:masterfrom
benjchristensen merged 2 commits intoReactiveX:masterfrom
Conversation
Performance increase from 7.7m to 8.8m ops/second Before: Benchmark (size) Mode Samples Mean Mean error Units r.u.PerfTransforms.mapTransformation 1 thrpt 5 7714453.187 362218.633 ops/s r.u.PerfTransforms.mapTransformation 1 thrpt 5 7527144.767 497816.471 ops/s After: Benchmark (size) Mode Samples Mean Mean error Units r.u.PerfTransforms.mapTransformation 1 thrpt 5 8853534.333 183494.242 ops/s r.u.PerfTransforms.mapTransformation 1 thrpt 5 8806958.403 452595.219 ops/s
benjchristensen
added a commit
that referenced
this pull request
May 22, 2014
Remove Subscription Wrapper from Observable.subscribe
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove Subscription Wrapper from Observable.subscribe
Performance increase from 7.7m to 8.8m ops/second
Before:
After:
Test can be run using: