Make interval work with multiple subscribers#379
Merged
benjchristensen merged 4 commits intoReactiveX:masterfrom Sep 13, 2013
Merged
Make interval work with multiple subscribers#379benjchristensen merged 4 commits intoReactiveX:masterfrom
interval work with multiple subscribers#379benjchristensen merged 4 commits intoReactiveX:masterfrom
Conversation
added 4 commits
September 13, 2013 09:11
…and added a test for staggered subscriptions with publish/connect, too
|
RxJava-pull-requests #276 FAILURE |
Contributor
Author
|
I feel innocent about that test failure. Looks like a sporadic timing problem of the |
benjchristensen
added a commit
that referenced
this pull request
Sep 13, 2013
Make `interval` work with multiple subscribers
Closed
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this pull request
Jan 9, 2014
…ribers Make `interval` work with multiple subscribers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per @samuelgruetter's comments in #55, I added some tests against
intervaltogether with multiple subscribers, and then proceeded to fix the behavior by wrapping it in another subscription function.I hope it's ok now.