Merged
Conversation
|
RxJava-pull-requests #372 FAILURE |
Member
|
Thank you @zsxwing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue in #417 is because current
mapimplementation violates the design guild:Now current
mapdoes not handle the error from thefuncparam which may be user codes. When the thread pool scheduler is involved, the error fromfuncwill throw to the outside and be handled byjava.util.concurrent.FutureTask. The error will be dropped so the observer will not see it.This PR used
SafeObserverto protectmapfrom user codes.