Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Fixed ReplaySubject leak#955

Merged
benjchristensen merged 1 commit intoReactiveX:masterfrom
akarnokd:ReplaySubjectLeakFix
Mar 13, 2014
Merged

Fixed ReplaySubject leak#955
benjchristensen merged 1 commit intoReactiveX:masterfrom
akarnokd:ReplaySubjectLeakFix

Conversation

@akarnokd
Copy link
Member

Fix for issue #939.

@cloudbees-pull-request-builder

RxJava-pull-requests #889 SUCCESS
This pull request looks good

@mttkay
Copy link
Contributor

mttkay commented Mar 12, 2014

I can confirm this fixes #939 for me, thanks @akarnokd !

This might in fact be the final nail in the coffin for any workarounds we used on Android to prevent Activities from leaking, this is great.

@mttkay
Copy link
Contributor

mttkay commented Mar 12, 2014

@benjchristensen do you think we could get this in for 0.17.1, that would be fantastic. It would simplify reasoning about requirements for Android operators a lot, since the use of cache and replay is quite common on Android and some design decisions for OperatorObserveFromAndroidComponent were made purely due to the existence of this bug (no one actually thought to question the correctness of the underlying operator back then, hah.)

benjchristensen added a commit that referenced this pull request Mar 13, 2014
@benjchristensen benjchristensen merged commit 5c3e416 into ReactiveX:master Mar 13, 2014
@akarnokd akarnokd deleted the ReplaySubjectLeakFix branch May 6, 2014 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants