Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

BugFix: Chain Subscription in TimeoutSubscriber and SerializedSubscriber#965

Merged
benjchristensen merged 1 commit intoReactiveX:masterfrom
zsxwing:fix-timeout-unsubscribe
Mar 25, 2014
Merged

BugFix: Chain Subscription in TimeoutSubscriber and SerializedSubscriber#965
benjchristensen merged 1 commit intoReactiveX:masterfrom
zsxwing:fix-timeout-unsubscribe

Conversation

@zsxwing
Copy link
Member

@zsxwing zsxwing commented Mar 15, 2014

This PR chains Subscription in TimeoutSubscriber and SerializedSubscriber. Found by @rbramw #951. Thanks for your unit tests, @rbramw

@cloudbees-pull-request-builder

RxJava-pull-requests #905 FAILURE
Looks like there's a problem with this pull request

@zsxwing
Copy link
Member Author

zsxwing commented Mar 15, 2014

I have no idea why rx.operators.OperationParallelMergeTest.testNumberOfThreadsOnScheduledMerge failed. In my local machine, it fails sometimes. Is it nondeterministic?

@zsxwing
Copy link
Member Author

zsxwing commented Mar 21, 2014

Rebased

@zsxwing zsxwing changed the title Chain Subscription in TimeoutSubscriber and SerializedSubscriber BugFix: Chain Subscription in TimeoutSubscriber and SerializedSubscriber Mar 21, 2014
@cloudbees-pull-request-builder

RxJava-pull-requests #915 SUCCESS
This pull request looks good

@benjchristensen
Copy link
Member

Thank you.

benjchristensen added a commit that referenced this pull request Mar 25, 2014
BugFix: Chain Subscription in TimeoutSubscriber and SerializedSubscriber
@benjchristensen benjchristensen merged commit 7e7aebf into ReactiveX:master Mar 25, 2014
@zsxwing zsxwing deleted the fix-timeout-unsubscribe branch March 28, 2014 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants