Move all bootstrap logic to build script

Author: JustinGrote

build.ps1

@@ -3,7 +3,7 @@
 # Licensed under the MIT License.
 <#
 .SYNOPSIS
-A bootstrap for Invoke-Build which will perform the rest of the process. This is mostly compatability for programs that still use it, normally you should use Invoke-Build directly unless you don't have invoke-build installed. For noninteractive use, be sure to specify -Confirm:$false to avoid prompts
+A bootstrap for Invoke-Build which will perform the rest of the process. This is mostly compatability for programs that still use it, normally you should use Invoke-Build directly unless you don't have invoke-build installed.
 #>
 #requires -version 5
 using namespace System.Management.Automation
@@ -31,6 +31,9 @@ $InvokeBuildVersion = '5.10.3'
 [hashset[string]]$commonParameters = ([PSCmdlet]::CommonParameters, [PSCmdlet]::OptionalCommonParameters) | ForEach-Object { $_ }
 $ibParams = @{}
 $ibParams.Task = ($PSBoundParameters.Keys | Where-Object { $_ -notin $commonParameters }) -join ','
+if (-not $ibParams.Task) {
+    $ibParams.Task = '.'
+}
 $commonParams = @{}
 $PSBoundParameters.GetEnumerator() | Where-Object Key -In $commonParameters | ForEach-Object {
     $commonParams[$PSItem.Key] = $PSItem.Value
@@ -42,111 +45,8 @@ try {
     Write-Verbose "Bootstrap: Invoke-Build $InvokeBuildVersion detected."
 } catch {
     Write-Warning "Invoke-Build $InvokeBuildVersion not detected. Installing..."
-    Install-Module -Name InvokeBuild -RequiredVersion $InvokeBuildVersion -Scope CurrentUser @commonParams
+    Install-Module -Name InvokeBuild -RequiredVersion $InvokeBuildVersion -Scope CurrentUser @commonParams -Force
 }
 
 Write-Verbose "Starting Invoke-Build $($ibParams.Task -join ', ')"
 & $invokeBuildCommand @ibParams
-
-# $NeededTools = @{
-#     VSCode = "Visual Studio Code"
-#     NodeJS = "Node.js 6.0 or higher"
-#     PowerShellGet = "PowerShellGet latest"
-#     InvokeBuild = "InvokeBuild latest"
-# }
-
-# function needsVSCode () {
-#     try {
-#             $vscodeVersion = (code -v)
-#             if (-not $vscodeVersion) {
-#                 Throw
-#             }
-#     } catch {
-#         try {
-#             $vscodeInsidersVersion = (code-insiders -v)
-#             if (-not $vscodeInsidersVersion) {
-#                 Throw
-#             }
-#         } catch {
-#             return $true
-#         }
-#     }
-#     return $false
-# }
-
-# function needsNodeJS () {
-#     try {
-#         $nodeJSVersion = node -v
-#     } catch {
-#         return $true
-#     }
-
-#     if ($nodeJSVersion -notmatch 'v(\d+\.\d+\.\d+)') {
-#         return $true
-#     }
-
-#     $nodeVer = [System.Version]$matches[1]
-#     return ($nodeVer.Major -lt 6)
-# }
-
-# function needsPowerShellGet () {
-#     if (Get-Module -ListAvailable -Name PowerShellGet) {
-#         return $false
-#     }
-#     return $true
-# }
-
-# function needsInvokeBuild () {
-#     if (Get-Module -ListAvailable -Name InvokeBuild) {
-#         return $false
-#     }
-#     return $true
-# }
-
-# function getMissingTools () {
-#     $missingTools = @()
-
-#     if (needsVSCode) {
-#         $missingTools += $NeededTools.VSCode
-#     }
-#     if (needsNodeJS) {
-#         $missingTools += $NeededTools.NodeJS
-#     }
-#     if (needsPowerShellGet) {
-#         $missingTools += $NeededTools.PowerShellGet
-#     }
-#     if (needsInvokeBuild) {
-#         $missingTools += $NeededTools.InvokeBuild
-#     }
-
-#     return $missingTools
-# }
-
-# function hasMissingTools () {
-#     return ((getMissingTools).Count -gt 0)
-# }
-
-# if ($Bootstrap) {
-#     $string = "Here is what your environment is missing:`n"
-#     $missingTools = getMissingTools
-#     if (($missingTools).Count -eq 0) {
-#         $string += "* nothing!`n`n Run this script without a flag to build or a -Clean to clean."
-#     } else {
-#         $missingTools | ForEach-Object {$string += "* $_`n"}
-#         $string += "`nAll instructions for installing these tools can be found on VSCode PowerShell's Github:`n" `
-#             + "https://github.com/PowerShell/vscode-powershell/blob/main/docs/development.md"
-#     }
-#     Write-Host "`n$string`n"
-# } elseif(hasMissingTools) {
-#     Write-Host "You are missing needed tools. Run './build.ps1 -Bootstrap' to see what they are."
-# } else {
-#     if($Clean) {
-#         Invoke-Build Clean
-#     }
-
-#     Invoke-Build Build
-
-#     if($Test) {
-#         Invoke-Build Test
-#     }
-# }

vscode-powershell.build.ps1

@@ -9,22 +9,34 @@ param(
     [string]$EditorServicesRepoPath = $null,
     # Keep this up to date with the version that vscode stable uses (see vscode help -> about)
     [Version]$RequiredNodeVersion = '16.14.2',
-    [PowerShell.Commands.ModuleSpecification]$RequiredModules = @(
+    # List of modules that are required for the build
+    [Microsoft.PowerShell.Commands.ModuleSpecification[]]$RequiredModules = @(
         @{ ModuleName = 'InvokeBuild'; ModuleVersion = '5.0.0' }
         @{ ModuleName = 'Pester'; ModuleVersion = '5.3.0' } #For PSES Build. TODO: Remove once we hook into PSES build script
         @{ ModuleName = 'PSScriptAnalyzer'; ModuleVersion = '1.21.0' } #For PSES Build
         @{ ModuleName = 'platyPS'; ModuleVersion = '0.14.0' } #For PSES Build
     )
 )
-$ErrorActionPreference = 'Stop'
+$SCRIPT:ErrorActionPreference = 'Stop'
 
 #Requires -Modules @{ ModuleName = "InvokeBuild"; ModuleVersion = "5.0.0" }
 
 #region Prerequisites
 
 task Prerequisites {
-    Assert-NodeVersion $RequiredNodeVersion -ErrorAction Continue
-    Assert-Module $RequiredModules -ErrorAction Continue
+    # We want all prereqs to run so we can tell the user everything they are missing, rather than them having to fix/check/fix/check/etc.
+    [ErrorRecord[]]$preRequisiteIssues = & {
+        Assert-NodeVersion $RequiredNodeVersion -ErrorAction Continue
+        Assert-Module $RequiredModules -ErrorAction Continue
+    } 2>&1
+
+    if ($preRequisiteIssues) {
+        $ErrorActionPreference = 'Continue'
+        Write-Warning 'The following prerequisites are not met. Please install them before continuing. Setup guidance can be found here: https://github.com/PowerShell/vscode-powershell/blob/main/docs/development.md'
+        $preRequisiteIssues | ForEach-Object { Write-Error $_ }
+    }
+    # We dont need to test for vscode anymore because we download it dynamically during the build.
+
 }
 
 function Assert-NodeVersion ($RequiredNodeVersion) {
@@ -118,7 +130,7 @@ task Restore RestoreEditorServices, RestoreNodeModules
 #endregion
 #region Clean tasks
 
-task Clean {
+task CleanExtension {
     Write-Host "`n### Cleaning vscode-powershell`n" -ForegroundColor Green
     Remove-BuildItem ./modules, ./out, ./node_modules, *.vsix
 }
@@ -153,7 +165,7 @@ task Build Restore, {
 #endregion
 #region Test tasks
 
-task Test Build, {
+task TestExtension {
     Write-Host "`n### Running extension tests" -ForegroundColor Green
     Invoke-BuildExec { & npm run test }
     # Reset the state of files modified by tests
@@ -191,4 +203,6 @@ task Package Build, {
 
 # High Level Tasks
 task Bootstrap Prerequisites
-task . Build, Test, Package
+task Clean CleanExtension, CleanEditorServices
+task Test Build, TestExtension, TestEditorServices
+task . Prerequisites, Build, Test, Package