Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Things that should be getters/utility functions #198

Open
10 tasks
joshua-dean opened this issue Oct 7, 2024 · 0 comments
Open
10 tasks

Things that should be getters/utility functions #198

joshua-dean opened this issue Oct 7, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@joshua-dean
Copy link
Collaborator

joshua-dean commented Oct 7, 2024

Making this an ongoing list rather than a bunch of isolated issues. Feel free to add more.

I'm listing the first name that comes to mind, not anything definitive. These are primarily to increase readability to maximum verbosity isn't always necessary. A lot of these fall under the "current subtask" so standardizing on an abbreviation like "cst" would be fine as long as it is documented.

  • ulabel.subtasks[st_key] -> ulabel.get_subtask(st_key)
  • ulabel.get_current_subtask().state -> ulabel.get_current_subtask_state() or ulabel.get_cst_state()
  • ulabel.get_current_subtask().state.is_in_progress -> ulabel.current_subtask_in_progress()
  • ulabel.get_current_subtask().state.is_in_brush_mode -> ulabel.currently_in_brush_mode()
  • ulabel.get_current_subtask().state.is_in_brush_mode -> ulabel.currently_in_erase_mode()
  • ulabel.get_current_subtask().annotations.access -> ulabel.get_current_annotations()
  • ulabel.get_current_subtask().state.visible_dialogs -> ulabel.get_visible_dialogs() (I think this implies current subtask, as others shouldn't produce dialogs, right?)
  • ulabel.get_current_subtask().annotations.access[this.get_current_subtask().state.active_id] -> ulabel.get_current_active_anno()
  • ulabel.get_current_subtask().actions.stream -> ulabel.get_current_action_stream()
  • $("#" + ulabel.config["container_id"]) -> ulabel.root_container_jq()
    • Maybe also a ulabel.root_container() for document.getElementById
@joshua-dean joshua-dean added the enhancement New feature or request label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant