Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GPS filtering to task creation flow #86

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

ejcunningham
Copy link
Contributor

@ejcunningham ejcunningham commented Jun 13, 2024

Add support to filter images by GPS location during task creation flow

PR fixes #82

Changes

  • Add latitude+longitude filters to the task creation form
  • Change Image model to default location attributes to invalid values rather than using required=false, which seems to be the same as defaulting to 0 (a valid value) rather than undefined
  • Plumb filters through the task POST endpoint and taskQueuer

Note the ticket specifies setting a placeholder text on the form fields, but placeholders appear to be broken on this whole form. Suggest we fix that bug as a separate task.

Test Plan:

  • Tested that the UI can correctly reflect filters in image-count
  • Verified taskQueuer finds the right files
  • Verified image preview shows the right files
  • Verified ground truth page and CSV exports still work properly with model changes
Screenshot 2024-06-13 at 7 41 25 AM

await GroundTruths.deleteForImage(id);
await LineDivisions.deleteForImage(id);
await SequencedPairs.deleteForImage(id);
deleteCascade: async function(id) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note there are no changes below this point, I just fixed the inconsistent indentation

Copy link
Member

@naknomum naknomum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks correct to me, except i am not sure if the original issue means the user should be prevented (or warned?) if they enter values outside of the valid ranges. might be a question for @TanyaStere42 to confirm the answer on.

for example, if a user enters a latitude value of 100, should they get a warning/error that they are out of range?

@TanyaStere42
Copy link
Member

hiya @naknomum ! Yes, the intention of the ticket is that values outside of the lat/long ranges listed should be disallowed from being entered.

Copy link
Member

@naknomum naknomum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per updated info (below), i am approving this now.

I talked to the customer and it seems like that validation is important but not blocking. We can go ahead and merge assuming there was nothing else in the code review, and I'll make a new ticket for the form validation (@TanyaStere42)

@naknomum naknomum merged commit 5824de6 into WildMeOrg:main Jun 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image EXIF GPS task filter
3 participants