Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit f2ff04f

Browse files
committed
Now all files are dependent upon config directory and not reading from .env file
1 parent 839791a commit f2ff04f

File tree

19 files changed

+121
-78
lines changed

19 files changed

+121
-78
lines changed

providers/EncryptionProvider.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ class EncryptionProvider extends ServiceProvider {
1313
* register () {
1414
this.app.singleton('Adonis/Src/Encryption', function (app) {
1515
const Encryption = require('../src/Encryption')
16-
const Env = app.use('Adonis/Src/Env')
17-
return new Encryption(Env)
16+
const Config = app.use('Adonis/Src/Config')
17+
return new Encryption(Config)
1818
})
1919
}
2020
}

providers/ResponseProvider.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,9 @@ class ResponseProvider extends ServiceProvider {
1414
this.app.singleton('Adonis/Src/Response', function (app) {
1515
const View = app.use('Adonis/Src/View')
1616
const Route = app.use('Adonis/Src/Route')
17+
const Config = app.use('Adonis/Src/Config')
1718
const Response = require('../src/Response')
18-
return new Response(View, Route)
19+
return new Response(View, Route, Config)
1920
})
2021
}
2122
}

providers/StaticProvider.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,9 @@ class StaticProvider extends ServiceProvider {
1313
* register () {
1414
this.app.bind('Adonis/Src/Static', function (app) {
1515
const Helpers = app.use('Adonis/Src/Helpers')
16+
const Config = app.use('Adonis/Src/Config')
1617
const Static = require('../src/Static')
17-
return new Static(Helpers)
18+
return new Static(Helpers, Config)
1819
})
1920
}
2021
}

providers/ViewProvider.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@ class ViewProvider extends ServiceProvider {
1313
* register () {
1414
this.app.singleton('Adonis/Src/View', function (app) {
1515
const Helpers = app.use('Adonis/Src/Helpers')
16-
const Env = app.use('Adonis/Src/Env')
16+
const Config = app.use('Adonis/Src/Config')
1717
const Route = app.use('Adonis/Src/Route')
1818
const View = require('../src/View')
19-
return new View(Helpers, Env, Route)
19+
return new View(Helpers, Config, Route)
2020
})
2121
}
2222
}

src/Encryption/index.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,16 @@ const crypto = require('crypto')
1010

1111
class Encryption {
1212

13-
constructor (Env) {
14-
this.appKey = Env.get('APP_KEY')
15-
this.algorithm = Env.get('ENCRYPTION', 'aes-256-cbc')
13+
constructor (Config) {
14+
this.appKey = Config.get('app.appKey')
15+
this.algorithm = Config.get('app.encryption.algorithm', 'aes-256-cbc')
1616

1717
/**
1818
* throwing error when APP_KEY is not defined as encryption
1919
* does not make sense without a key
2020
*/
2121
if (!this.appKey) {
22-
throw new Error('Encryption cannot work without APP_KEY')
22+
throw new Error('Encryption cannot work without application key. Define appKey inside app config')
2323
}
2424
}
2525

src/Request/index.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ class Request {
3232
* secret to parse and decrypt cookies
3333
* @type {String}
3434
*/
35-
this.secret = process.env.APP_KEY
35+
this.secret = this.config.get('app.appKey')
3636

3737
/**
3838
* holding references to cookies once they
@@ -171,7 +171,7 @@ class Request {
171171
* @public
172172
*/
173173
ip () {
174-
return nodeReq.ip(this.request, this.config.get('http.trustProxy'))
174+
return nodeReq.ip(this.request, this.config.get('app.http.trustProxy'))
175175
}
176176

177177
/**
@@ -182,7 +182,7 @@ class Request {
182182
* @public
183183
*/
184184
ips () {
185-
return nodeReq.ips(this.request, this.config.get('http.trustProxy'))
185+
return nodeReq.ips(this.request, this.config.get('app.http.trustProxy'))
186186
}
187187

188188
/**
@@ -203,7 +203,7 @@ class Request {
203203
* @public
204204
*/
205205
subdomains () {
206-
return nodeReq.subdomains(this.request, this.config.get('http.trustProxy'), this.config.get('http.subdomainOffset'))
206+
return nodeReq.subdomains(this.request, this.config.get('app.http.trustProxy'), this.config.get('app.http.subdomainOffset'))
207207
}
208208

209209
/**
@@ -234,7 +234,7 @@ class Request {
234234
* @public
235235
*/
236236
hostname () {
237-
return nodeReq.hostname(this.request, this.config.get('http.trustProxy'))
237+
return nodeReq.hostname(this.request, this.config.get('app.http.trustProxy'))
238238
}
239239

240240
/**

src/Response/index.js

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ const nodeRes = require('node-res')
1010
const nodeCookie = require('node-cookie')
1111
let viewInstance = null
1212
let routeInstance = null
13+
let configInstance = null
1314

1415
/**
1516
* @class Response class to be passed on
@@ -20,6 +21,9 @@ class Response {
2021
constructor (request, response) {
2122
this.request = request
2223
this.response = response
24+
if (configInstance.get('app.http.setPoweredBy', true)) {
25+
nodeRes.header(this.response, 'x-powered-by', 'adonis')
26+
}
2327
}
2428

2529
/**
@@ -112,7 +116,7 @@ class Response {
112116
* @public
113117
*/
114118
jsonp (body) {
115-
const callback = this.request.input('callback')
119+
const callback = this.request.input('callback') || configInstance.get('app.http.jsonpCallback')
116120
nodeRes.jsonp(this.request, this.response, body, callback)
117121
}
118122

@@ -198,7 +202,7 @@ class Response {
198202
* @public
199203
*/
200204
cookie (key, value, options) {
201-
const secret = process.env.APP_KEY
205+
const secret = configInstance.get('app.appKey')
202206
const encrypt = !!secret
203207
nodeCookie.create(this.request.request, this.response, key, value, options, secret, encrypt)
204208
return this
@@ -224,9 +228,10 @@ class Response {
224228
* view instance.
225229
*/
226230
class ResponseBuilder {
227-
constructor (View, Route) {
231+
constructor (View, Route, Config) {
228232
viewInstance = View
229233
routeInstance = Route
234+
configInstance = Config
230235
return Response
231236
}
232237
}

src/Server/index.js

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,15 @@ class Server {
6969
const session = new this.Session(req, res)
7070
const requestUrl = request.url()
7171
request.session = session
72+
73+
/**
74+
* making request verb/method based upon _method or falling
75+
* back to original method
76+
* @type {String}
77+
*/
78+
const method = request.input('_method', request.method())
79+
const resolvedRoute = this.Route.resolve(requestUrl, method, request.hostname())
80+
request._params = resolvedRoute.params
7281
this.log.verbose('request on url %s ', req.url)
7382

7483
/**
@@ -78,14 +87,6 @@ class Server {
7887
* @return {Function}
7988
*/
8089
const finalHandler = function * () {
81-
/**
82-
* making request verb/method based upon _method or falling
83-
* back to original method
84-
* @type {String}
85-
*/
86-
const method = request.input('_method', request.method())
87-
const resolvedRoute = self.Route.resolve(requestUrl, method, request.hostname())
88-
request._params = resolvedRoute.params
8990
self._finalHandler(resolvedRoute, request, response)
9091
}
9192
helpers.respondRequest(this.middleware, request, response, finalHandler)

src/Session/SessionManager/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class SessionManager {
2525
* @private
2626
*/
2727
_getSessionCookie () {
28-
const secret = process.env.APP_KEY
28+
const secret = this.constructor.config.get('app.appKey')
2929
const decrypt = !!secret
3030
return nodeCookie.parse(this.request, secret, decrypt)[this.constructor.options.cookie]
3131
}
@@ -37,7 +37,7 @@ class SessionManager {
3737
* @private
3838
*/
3939
_setSessionCookie (session) {
40-
const secret = process.env.APP_KEY
40+
const secret = this.constructor.config.get('app.appKey')
4141
const encrypt = !!secret
4242

4343
/**

src/Session/index.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ class Session {
7474
}
7575
SessionManager.driver = driverInstance
7676
SessionManager.options = sessionOptions
77+
SessionManager.config = Config
7778
return SessionManager
7879
}
7980

0 commit comments

Comments
 (0)