Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Sendgrid: support more entities #2117

Closed
Manutd34 opened this issue Feb 18, 2021 · 2 comments
Closed

Source Sendgrid: support more entities #2117

Manutd34 opened this issue Feb 18, 2021 · 2 comments

Comments

@Manutd34
Copy link

Manutd34 commented Feb 18, 2021

I am using sendgrid 0.1.2 and not listing out all tables as expected. Added to that in snowflake I see 2 tables one as transient and other as normal table.

Please look at slack conversation for more details and let me know if you need anything from my end.

https://app.slack.com/client/T01AB4DDR2N/C01A4CAP81L/thread/C01A4CAP81L-1613580745.241500

┆Issue is synchronized with this Asana task by Unito

@sherifnada sherifnada added area/connectors Connector related issues type/enhancement New feature or request labels Feb 21, 2021
@sherifnada
Copy link
Contributor

This issue is asking to support more of the entities available in the Sendgrid API. @Manutd34 is potentially interested in contributing this to the connector. Some pointers on getting started:

Prerequisites

  1. Make sure you have python 3.7
  2. clone the Airbyte repo
  3. navigate to airbyte-integrations/connectors/source-sendgrid then run python -m venv .venv follwed by source .venv/bin/activate to activate the virtual environment for developing this connector

Make the change

  1. Adding the schema of the entities being pulled from the sendgrid pi into airbyte-integrations/connectors/source-sendgrid/source_sendgrid/schemas
  2. make the changes to https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/connectors/source-sendgrid/source_sendgrid/client.py to add the new streams. each stream can be added by adding a method stream__<stream_name>.
  3. adjusting integration_tests/confgiured_catalog.json to contain the new entities

Create a PR

  1. create a PR that gives maintainers right to edit (so we can make some small adjustments to the code related to releasing the new connector version)

At any time if you have any questions or would like any assistance, please reach out to us on Slack or create a Draft PR with your questions. We strive to answer any questions or PRs quickly.

@sherifnada sherifnada changed the title Sendgrid: Not listing out all tables Source Sendgrid: support more entities Nov 17, 2021
@bleonard bleonard added the frozen Not being actively worked on label Mar 22, 2024
@cgardens
Copy link
Contributor

closing as stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants