Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single credentials' storage #5386

Open
antixar opened this issue Aug 13, 2021 · 1 comment
Open

Single credentials' storage #5386

antixar opened this issue Aug 13, 2021 · 1 comment

Comments

@antixar
Copy link
Contributor

antixar commented Aug 13, 2021

Current problem state

A current workflow for support of all project secrets is difficult and inconvenient:

  • Every developers should add/update 3 different files if a connector secret key is changed
  • Not all developers can add GitHub secrets. Sure, there are a set of responsible people whom do it but sometimes we need to troubleshoot of access issues and it is not comfortable to pull them constantly.
  • Support of 2 credentials' storages: GitHub Secrets and LostPass

Possible solution

Update of the CI workflow:

  • CI script will try to load necessary config files from the LastPass storage primarily. There is a console utility for this. A name of LastPass note must be same with a github secret's name. If these notes are not exists into LastPass, CI will use the old logic(using of GitHub secrets)
  • simplify support of credentials' variables:
    • using of connector unique names as variable prefixes. e.g. connector: source-s3 => the variable prefix: SOURCE_S3_. And CI will load all values with necessary prefixes only.
    • keep a name of target file into a secret's name. e.g.:
      • default value: SOURCE_S3_CREDS. This value will be saved to the folder ./source-s3/secrets/config.json
      • custom value: SOURCE_S3_CREDS_custom_config.json. This value will be saved to the folder ./source-s3/secrets/custom_config.json
@antixar antixar added the type/enhancement New feature or request label Aug 13, 2021
@haf
Copy link

haf commented Aug 24, 2021

A simpler solution would be to add all secrets into the repository. You can create a public-private key (Curve25519 for example), encrypt all secrets to source code with the public key and decrypt the secret in CI with the private key. https://pynacl.readthedocs.io/en/latest/public/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants