Improvement

begeekmyfriend · begeekmyfriend · commit 4fab7e0a488a · 2024-06-12T11:51:32.000+08:00
Signed-off-by: begeekmyfriend &lt;begeekmyfriend@gmail.com&gt;
diff --git a/0015_three_sum/three_sum.c b/0015_three_sum/three_sum.c
@@ -43,7 +43,7 @@ int** threeSum(int* nums, int numsSize, int* returnSize, int** returnColumnSizes
     int i, j, capacity = 50000;
     int **results = malloc(capacity * sizeof(int *));
     for (i = 0; i < numsSize - 2; i++) {
-        if (i == 0 || i > 0 && nums[i] != nums[i - 1]) {
+        if (i == 0 || (i > 0 && nums[i] != nums[i - 1])) {
             two_sum(nums, i + 1, numsSize - 1, -nums[i], results, returnSize);
         }
     }
@@ -58,14 +58,18 @@ int** threeSum(int* nums, int numsSize, int* returnSize, int** returnColumnSizes
 
 int main(void)
 {
-    int i, count;
+    int i, j, count;
     //int nums[] = { -1, 0, 1, 2, -1, -4 };
     //int nums[] = { 0, 0, 0 };
     //int nums[] = { -1, 0, 1, 0 };
     int nums[] = {-2,0,0,2,2};
-    int **triplets = threeSum(nums, sizeof(nums) / sizeof(*nums), &count);
+    int *col_sizes;
+    int **triplets = threeSum(nums, sizeof(nums) / sizeof(*nums), &count, &col_sizes);
     for (i = 0; i < count; i++) {
-        printf("%d %d %d\n", triplets[i][0], triplets[i][1], triplets[i][2]);
+        for (j = 0; j < col_sizes[i]; j++) {
+            printf("%d \n", triplets[i][j]);
+        }
+        printf("\n");
     }
 
     return 0;
diff --git a/0018_four_sum/four_sum.c b/0018_four_sum/four_sum.c
@@ -68,13 +68,16 @@ int** fourSum(int* nums, int numsSize, int target, int* returnSize, int** return
 
 int main(void)
 {
-    int i, count, target = 11, *col_sizes;
+    int i, j, count, target = 11, *col_sizes;
     //int nums[] = { 1, 0, -1, 0, -2, 2 };
     //int nums[] = { -3, -2, -1, 0, 0, 1, 2, 3 };
     int nums[] = { 0, 1, 5, 0, 1, 5, 5, -4 };
     int **quadruplets = fourSum(nums, sizeof(nums) / sizeof(*nums), target, &count, &col_sizes);
     for (i = 0; i < count; i++) {
-        printf("%d %d %d %d\n", quadruplets[i][0], quadruplets[i][1], quadruplets[i][2], quadruplets[i][3]);
+        for (j = 0; j < col_sizes[i]; j++) {
+            printf("%d ", quadruplets[i][j]);
+        }
+        printf("\n");
     }
 
     return 0;
diff --git a/0046_permutations/permutations.c b/0046_permutations/permutations.c
@@ -88,10 +88,10 @@ int main(int argc, char **argv)
         nums[i] = atoi(argv[i + 1]);
     }
 
-    int *size;
-    int **lists = permute(nums, argc - 1, &count, &size);
+    int *col_sizes;
+    int **lists = permute(nums, argc - 1, &count, &col_sizes);
     for (i = 0; i < count; i++) {
-        for (j = 0; j < argc - 1; j++) {
+        for (j = 0; j < col_sizes[i]; j++) {
             printf("%d", lists[i][j]);
         }
         putchar('\n');
diff --git a/0047_permutations_ii/permutations.c b/0047_permutations_ii/permutations.c
@@ -72,10 +72,10 @@ int main(int argc, char **argv)
         nums[i] = atoi(argv[i + 1]);
     }
 
-    int *size;
-    int **lists = permute(nums, argc - 1, &count, &size);
+    int *col_sizes;
+    int **lists = permute(nums, argc - 1, &count, &col_sizes);
     for (i = 0; i < count; i++) {
-        for (j = 0; j < argc - 1; j++) {
+        for (j = 0; j < col_sizes[i]; j++) {
             printf("%d", lists[i][j]);
         }
         putchar('\n');
diff --git a/0199_binary_tree_right_side_view/bst_right.c b/0199_binary_tree_right_side_view/bst_right.c
@@ -90,9 +90,7 @@ static void node_free(struct queue_node *qn, struct list_head *free_list)
 }
 
 /**
- ** Return an array of arrays of size *returnSize.
- ** The sizes of the arrays are returned as *returnColumnSizes array.
- ** Note: Both returned array and *returnColumnSizes array must be malloced, assume caller calls free().
+ ** The returned array must be malloced, assume caller calls free().
  **/
 static int* rightSideView(struct TreeNode* root, int* returnSize)
 {

Original file line number	Diff line number	Diff line change
`@@ -88,10 +88,10 @@ int main(int argc, char **argv)`
`88`	`88`	`nums[i] = atoi(argv[i + 1]);`
`89`	`89`	`}`
`90`	`90`
`91`		`- int *size;`
`92`		`- int **lists = permute(nums, argc - 1, &count, &size);`
	`91`	`+ int *col_sizes;`
	`92`	`+ int **lists = permute(nums, argc - 1, &count, &col_sizes);`
`93`	`93`	`for (i = 0; i < count; i++) {`
`94`		`- for (j = 0; j < argc - 1; j++) {`
	`94`	`+ for (j = 0; j < col_sizes[i]; j++) {`
`95`	`95`	`printf("%d", lists[i][j]);`
`96`	`96`	`}`
`97`	`97`	`putchar('\n');`
Original file line number	Diff line number	Diff line change
`@@ -72,10 +72,10 @@ int main(int argc, char **argv)`
`72`	`72`	`nums[i] = atoi(argv[i + 1]);`
`73`	`73`	`}`
`74`	`74`
`75`		`- int *size;`
`76`		`- int **lists = permute(nums, argc - 1, &count, &size);`
	`75`	`+ int *col_sizes;`
	`76`	`+ int **lists = permute(nums, argc - 1, &count, &col_sizes);`
`77`	`77`	`for (i = 0; i < count; i++) {`
`78`		`- for (j = 0; j < argc - 1; j++) {`
	`78`	`+ for (j = 0; j < col_sizes[i]; j++) {`
`79`	`79`	`printf("%d", lists[i][j]);`
`80`	`80`	`}`
`81`	`81`	`putchar('\n');`
Original file line number	Diff line number	Diff line change
`@@ -90,9 +90,7 @@ static void node_free(struct queue_node qn, struct list_head free_list)`
`90`	`90`	`}`
`91`	`91`
`92`	`92`	`/**`
`93`		`- ** Return an array of arrays of size *returnSize.`
`94`		`- ** The sizes of the arrays are returned as *returnColumnSizes array.`
`95`		`- ** Note: Both returned array and *returnColumnSizes array must be malloced, assume caller calls free().`
	`93`	`+ ** The returned array must be malloced, assume caller calls free().`
`96`	`94`	`**/`
`97`	`95`	`static int* rightSideView(struct TreeNode* root, int* returnSize)`
`98`	`96`	`{`