Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client crushed when local user profile path contains non-ascii characters #440

Open
OlkhinAG opened this issue Nov 27, 2023 · 0 comments
Open

Comments

@OlkhinAG
Copy link

Describe the bug
Client crash when installing any service on server.
event log shows error code 0xc0000409

Spotted on windows 10.
Tracked it to sftpFileCopy function, exception raises on accessing localPath.
Problem is that QTemporaryFile created in user profile and when path converted to std::string it makes it utf8, but std file functions on windows do not understand uft8.

replaced line

error = m_sshClient.sftpFileCopy(overwriteMode, localFile.fileName().toStdString(), remotePath.toStdString(),
                                     "non_desc");

with

error = m_sshClient.sftpFileCopy(overwriteMode, localFile.fileName().toLocal8Bit().toStdString(), remotePath.toStdString(),
                                     "non_desc");

in \client\core\servercontroller.cpp and error gone

maybe using std::filesystem::path in sftpFileCopy is better idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant