compact impl

Author: Will Fleming

lib/cc/engine/csslint.rb

@@ -1,11 +1,14 @@
 require "json"
 require "nokogiri"
+require "ostruct"
 require "shellwords"
 
 module CC
   module Engine
     MissingAttributesError = Class.new(StandardError)
 
+    DEFAULT_IDENTIFIER = OpenStruct.new(value: "parse-error")
+
     class CSSlint
       autoload :CheckDetails, "cc/engine/csslint/check_details"
 
@@ -21,12 +24,7 @@ def run
             path = file['name'].sub(/\A#{@directory}\//, '')
             file.children.each do |node|
               next unless node.name == "error"
-              issue =
-                if node.attributes.key?("identifier")
-                  create_issue(node, path)
-                else
-                  create_error(node, path)
-                end
+              issue = create_issue(node, path)
               puts("#{issue.to_json}\0")
             end
           end
@@ -37,7 +35,7 @@ def run
 
       # rubocop:disable Metrics/MethodLength
       def create_issue(node, path)
-        check_name = node.attributes.fetch("identifier").value
+        check_name = node.attributes.fetch("identifier", DEFAULT_IDENTIFIER).value
         check_details = CheckDetails.fetch(check_name)
 
         {
@@ -65,33 +63,6 @@ def create_issue(node, path)
       end
       # rubocop:enable Metrics/MethodLength
 
-      # rubocop:disable Metrics/MethodLength
-      def create_error(node, path)
-        {
-          type: "issue",
-          check_name: "parse-error",
-          description: node.attributes.fetch("message").value,
-          categories: ["Bug Risk"],
-          remediation_points: 5_000,
-          location: {
-            path: path,
-            positions: {
-              begin: {
-                line: node.attributes.fetch("line").value.to_i,
-                column: node.attributes.fetch("column").value.to_i
-              },
-              end: {
-                line: node.attributes.fetch("line").value.to_i,
-                column: node.attributes.fetch("column").value.to_i
-              }
-            }
-          }
-        }
-      rescue KeyError => ex
-        raise MissingAttributesError, "#{ex.message} on XML error '#{node}' when analyzing file '#{path}'"
-      end
-      # rubocop:enable Metrics/MethodLength
-
       def results
         @results ||= Nokogiri::XML(csslint_xml)
       end

lib/cc/engine/csslint/check_details.rb

@@ -19,6 +19,7 @@ class CheckDetails
           "import" => { categories: "Bug Risk" },
           "known-properties" => { categories: "Bug Risk" },
           "overqualified-elements" => { categories: "Bug Risk" },
+	  "parse-error" => { categories: "Bug Risk" },
           "regex-selectors" => { categories: "Bug Risk" },
           "shorthand" => { categories: "Bug Risk" },
           "star-property-hack" => { categories: "Compatibility" },