refactor(check): remove unnecessary variable

bearomorphism · Lee-W · commit fe72043eeec8 · 2025-05-22T11:15:53.000+08:00
diff --git a/commitizen/commands/check.py b/commitizen/commands/check.py
@@ -72,15 +72,11 @@ def __call__(self):
             raise NoCommitsFoundError(f"No commit found with range: '{self.rev_range}'")
 
         pattern = self.cz.schema_pattern()
-        ill_formatted_commits = [
-            commit
-            for commit in commits
-            if not self.validate_commit_message(commit.message, pattern)
-        ]
         displayed_msgs_content = "\n".join(
             [
                 f'commit "{commit.rev}": "{commit.message}"'
-                for commit in ill_formatted_commits
+                for commit in commits
+                if not self.validate_commit_message(commit.message, pattern)
             ]
         )
         if displayed_msgs_content:

Original file line number	Diff line number	Diff line change
`@@ -72,15 +72,11 @@ def __call__(self):`
`72`	`72`	`raise NoCommitsFoundError(f"No commit found with range: '{self.rev_range}'")`
`73`	`73`
`74`	`74`	`pattern = self.cz.schema_pattern()`
`75`		`- ill_formatted_commits = [`
`76`		`- commit`
`77`		`- for commit in commits`
`78`		`- if not self.validate_commit_message(commit.message, pattern)`
`79`		`- ]`
`80`	`75`	`displayed_msgs_content = "\n".join(`
`81`	`76`	`[`
`82`	`77`	`f'commit "{commit.rev}": "{commit.message}"'`
`83`		`- for commit in ill_formatted_commits`
	`78`	`+ for commit in commits`
	`79`	`+ if not self.validate_commit_message(commit.message, pattern)`
`84`	`80`	`]`
`85`	`81`	`)`
`86`	`82`	`if displayed_msgs_content:`