Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Not all versions in files get replaced #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Peter-Slump opened this issue Apr 9, 2021 · 5 comments
Closed

Not all versions in files get replaced #371

Peter-Slump opened this issue Apr 9, 2021 · 5 comments

Comments

@Peter-Slump
Copy link
Contributor

Description

Not all versions are replaced anymore.

In my project I create an Docker image based on the version tag and replace the version in a docker-compose file. However this version is not replaced since recent changes:

cd7018e#diff-ed9bead31489109a8441fbfb00d2ddec00198489b0702bab164825c2d3bd9b4f

Regex is invalid for detecting versions.

Steps to reproduce

  1. Create a file e.g. docker-compose.py
  2. Add version for an image: image: my-container:v0.11.1
  3. Bump version using commitizen

Current behavior

Version is not updated in file

Desired behavior

Version is also updated in file

Environment

cd7018e#diff-ed9bead31489109a8441fbfb00d2ddec00198489b0702bab164825c2d3bd9b4f

bump.py:192

  • commitizen version: 2.17.0
  • python version: 3.8.7
  • operating system: Linux
@Lee-W
Copy link
Member

Lee-W commented Apr 9, 2021

Hi, we're recently working on it. You could follow the discussion on #370. or try 2.16.0.

@woile
Copy link
Member

woile commented Apr 10, 2021

Please check again using v2.17.2, it should fix it 🎉

@Peter-Slump
Copy link
Contributor Author

Sorry the issues is not resolved in v2.17.2. I've create a PR to show the issue and also applied a fix for it. Please check.

@woile
Copy link
Member

woile commented Apr 22, 2021

Thanks @Peter-Slump !! We have also released version 2.17.3 which in theory should finally fix this, could you check first with that version, if it solves your issue.

Thanks 👍🏻

@Peter-Slump
Copy link
Contributor Author

Hi @woile I just ran the CI/CD pipeline based on 2.17.3 however it was not fixed there. Please view my PR to find out what the exact issue is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants