Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dashboard app port configurable #4136

Closed
jsbrain opened this issue Feb 23, 2022 · 3 comments
Closed

Make dashboard app port configurable #4136

jsbrain opened this issue Feb 23, 2022 · 3 comments
Labels
backend:server Issues relating to Cube Core's Server enhancement New feature proposal help wanted Community contributions are welcome.

Comments

@jsbrain
Copy link

jsbrain commented Feb 23, 2022

https://github.com/cube-js/cube.js/blob/7d2cf5469ea62fe20f18fc60044e0fd88d233ecd/packages/cubejs-server-core/src/core/server.ts#L414

Apparently, the dashboard app port is hardcoded which is a bummer if one already has an app running on port 3000.

Manually "hacking" the port in the package.json to "react scripts start --port 3111" does start the dashboard on the other port but the start command will be messy as my logs show:

cube_1   | 
cube_1   | > dashboard-app@0.1.0 start /cube/conf/dashboard-app
cube_1   | > react-scripts start --port 3111 "--port" "3000" "--host" "0.0.0.0"
cube_1   | 

Also it doesn't help much as the dashboard while starting on port 3111 won't be connected to the playground.

This means one always has to reconfigure a potentially already configured application to get the dashboard app up and running and working with the playground.

Is there any specific reason why it's implemented like that or am I missing something here?

@jsbrain
Copy link
Author

jsbrain commented Feb 23, 2022

Having CUBEJS_DASHBOARD_APP_PORT would be amazing and easy to implement (I think)?

@paveltiunov paveltiunov added enhancement New feature proposal help wanted Community contributions are welcome. labels Feb 23, 2022
@github-actions
Copy link

If you are interested in working on this issue, please leave a comment below and we will be happy to assign the issue to you.
If this is the first time you are contributing a Pull Request to Cube.js, please check our contribution guidelines.
You can also post any questions while contributing in the #contributors channel in the Cube.js Slack.

@paveltiunov paveltiunov added the backend:server Issues relating to Cube Core's Server label Feb 23, 2022
@igorlukanin
Copy link
Member

Dashboard app generation was removed from Cube Core long time ago.

@igorlukanin igorlukanin closed this as not planned Won't fix, can't repro, duplicate, stale Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:server Issues relating to Cube Core's Server enhancement New feature proposal help wanted Community contributions are welcome.
Projects
None yet
Development

No branches or pull requests

3 participants