-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix: excessive scrollbar on quality page #8729
Conversation
WalkthroughThe changes involve modifications to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UI
participant Component
User->>UI: Interacts with quality control component
UI->>Component: Render updated layout
Component-->>UI: Display adjusted heights
UI-->>User: Show modified interface
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🔇 Additional comments (2)cvat-ui/src/components/quality-control/styles.scss (2)
The max-height increase of 1 grid unit is minimal, but please ensure this fixes the intended UI issue without causing any content overlap with adjacent elements. Consider documenting the reason for this specific height adjustment in a code comment to help future maintainers understand the precise measurement requirement.
Changing from
Consider using CSS Grid or Flexbox for more flexible layouts that can adapt to different content sizes and viewport dimensions. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8729 +/- ##
========================================
Coverage 74.18% 74.18%
========================================
Files 401 401
Lines 43513 43513
Branches 3953 3953
========================================
+ Hits 32281 32282 +1
+ Misses 11232 11231 -1
|
Motivation and context
Fix for scaling in #8698 produced excessive scrollbar even for 100%
(for quality placeholder and management tab with full table of gt frames)
This hotfix fixes it. Scrollbar should be visible only on scaling
How has this been tested?
Checklist
develop
branch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.