Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit e01b063

Browse files
committed
Merge pull request #119 from ZEROFAIL/bugfix/crash_on_null_included_to_one_relation
bugfix in extract_included
2 parents a09c200 + 143a0cd commit e01b063

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

rest_framework_json_api/utils.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -415,9 +415,9 @@ def extract_included(fields, resource, resource_instance, included_resources):
415415

416416
try:
417417
included_resources.remove(field_name)
418+
new_included_resources = [key.replace('%s.' % field_name, '', 1) for key in included_resources]
418419
relation_instance_or_manager = getattr(resource_instance, field_name)
419420
serializer_data = resource.get(field_name)
420-
new_included_resources = [key.replace('%s.' % field_name, '', 1) for key in included_resources]
421421
except ValueError:
422422
# Skip fields not in requested included resources
423423
continue
@@ -429,6 +429,8 @@ def extract_included(fields, resource, resource_instance, included_resources):
429429

430430
if isinstance(field, RelatedField):
431431
serializer_class = included_serializers.get(field_name)
432+
if relation_instance_or_manager is None:
433+
continue
432434
field = serializer_class(relation_instance_or_manager, context=context)
433435
serializer_data = field.data
434436

0 commit comments

Comments
 (0)