refactor

Author: fishercoder1534

fishercoder_codestyle.xml

@@ -28,9 +28,11 @@
 
     <!-- Checks for whitespace                               -->
     <!-- See http://checkstyle.sf.net/config_whitespace.html -->
-    <!--<module name="FileTabCharacter">
-      <property name="eachLine" value="false"/>
-    </module>-->
+    <!--this cannot be enabled because right now Intellij CE cannot import my fishercoder_codestyle.xml as -->
+    <!--my chosen Java code style-->
+    <!--<module name="FileTabCharacter">-->
+      <!--<property name="eachLine" value="false"/>-->
+    <!--</module>-->
 
     <!--<module name="SuppressionCommentFilter">-->
         <!--<property name="offCommentFormat" value="CHECKSTYLE_OFF\: ([\w\|]+)"/>-->

src/main/java/com/fishercoder/common/utils/Notes.java

@@ -1,6 +1,3 @@
-/**
- * 
- */
 package com.fishercoder.common.utils;
 
 import java.lang.annotation.Retention;
@@ -9,17 +6,17 @@
 @Retention(RetentionPolicy.SOURCE)
 public @interface Notes {
 
-	String todo() default "";
+    String todo() default "";
 
-	String problemReview() default "";
+    String problemReview() default "";
 
-	String issue() default "";
+    String issue() default "";
 
-	String context() default ""; // this variable is used to state how I solved
-									// this problem, whether completely made it
-									// myself, or copied it from online, or a
-									// combination of both approaches.
+    String context() default ""; // this variable is used to state how I solved
+    // this problem, whether completely made it
+    // myself, or copied it from online, or a
+    // combination of both approaches.
 
-	boolean needsReview() default true;
+    boolean needsReview() default true;
 
 }

src/main/java/com/fishercoder/common/utils/TreeUtils.java

@@ -7,55 +7,51 @@
 
 import java.util.*;
 
-
 /**
  * This is a util class to contain all tree related methods.
  */
 public class TreeUtils {
-
-	/**
-	 * This method is to construct a normal binary tree. The input reads like
-	 * this for [5, 3, 6, 2, 4, null, null, 1]:
-
-		       5
-	         /   \
-	        3     6
-	       / \    / \
-	      2   4  #   #
-	     /
-	    1 
-	    
-	 */
-	@Notes(context = "This is usually how Leetcode OJ passes a binary tree into testing: "
-			+ "https://leetcode.com/faq/#binary-tree, I wrote this function for my own ease of testing when copying"
-			+ "the test case from Leetcode in the form of [1, null, 2, 3].")
-	public static TreeNode constructBinaryTree(List<Integer> treeValues) {
-		TreeNode root = new TreeNode(treeValues.get(0));
-		Queue<TreeNode> queue = new LinkedList<>();
-		queue.offer(root);
-		for (int i = 1; i < treeValues.size(); i++) {
-			TreeNode curr = queue.poll();
-			if (treeValues.get(i) != null) {
-				curr.left = new TreeNode(treeValues.get(i));
-				queue.offer(curr.left);
-			}
-			if (++i < treeValues.size() && treeValues.get(i) != null) {
-				curr.right = new TreeNode(treeValues.get(i));
-				queue.offer(curr.right);
-			}
+/**
+* This method is to construct a normal binary tree. The input reads like
+* this for [5, 3, 6, 2, 4, null, null, 1]:
+               5
+             /   \
+            3     6
+           / \    / \
+          2   4  #   #
+         /
+        1
+*/
+@Notes(context = "This is usually how Leetcode OJ passes a binary tree into testing: "
+		+ "https://leetcode.com/faq/#binary-tree, I wrote this function for my own ease of testing when copying"
+		+ "the test case from Leetcode in the form of [1, null, 2, 3].")
+public static TreeNode constructBinaryTree(List<Integer> treeValues) {
+	TreeNode root = new TreeNode(treeValues.get(0));
+	Queue<TreeNode> queue = new LinkedList<>();
+	queue.offer(root);
+	for (int i = 1; i < treeValues.size(); i++) {
+		TreeNode curr = queue.poll();
+		if (treeValues.get(i) != null) {
+			curr.left = new TreeNode(treeValues.get(i));
+			queue.offer(curr.left);
+		}
+		if (++i < treeValues.size() && treeValues.get(i) != null) {
+			curr.right = new TreeNode(treeValues.get(i));
+			queue.offer(curr.right);
 		}
-		return root;
 	}
-	
+	return root;
+}
+
 	public static void printBinaryTree(TreeNode root) {
 		CommonUtils.println("\nPrinting out the binary tree in a very visual manner as below:\n");
-		
+
 		// imitating from BTreePrinter class
 		int maxLevel = TreeUtils.maxLevel(root);
 
 		printNodeInternal(Collections.singletonList(root), 1, maxLevel);
 	}
-	
+
 	private static int maxLevel(TreeNode root) {
 		if (root == null) {
 			return 0;
@@ -64,7 +60,7 @@ private static int maxLevel(TreeNode root) {
 		return Math.max(TreeUtils.maxLevel(root.left),
 				TreeUtils.maxLevel(root.right)) + 1;
 	}
-	
+
 	private static void printNodeInternal(
 			List<TreeNode> list, int level, int maxLevel) {
 		if (list.isEmpty() || CommonUtils.isAllElementsNull(list))
@@ -122,13 +118,13 @@ private static void printNodeInternal(
 
 		printNodeInternal(newNodes, level + 1, maxLevel);
 	}
-	
-	public static void inOrderTraversal(TreeNode root){
+
+	public static void inOrderTraversal(TreeNode root) {
 		inOrder(root);
 	}
 
 	private static void inOrder(TreeNode root) {
-		if(root == null) {
+		if (root == null) {
 			return;
 		}
 		inOrder(root.left);