Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RGBGFX does not validate tile indices #1420

Closed
ISSOtm opened this issue Jul 25, 2024 · 1 comment · Fixed by #1425
Closed

RGBGFX does not validate tile indices #1420

ISSOtm opened this issue Jul 25, 2024 · 1 comment · Fixed by #1425
Assignees
Labels
bug Unexpected behavior / crashes; to be fixed ASAP! rgbgfx This affects RGBGFX
Milestone

Comments

@ISSOtm
Copy link
Member

ISSOtm commented Jul 25, 2024

% rgbgfx -r 40 -t bg_currents.bin -b 1 -o tileset.2bpp map.png
/usr/include/c++/14.1.1/bits/stl_vector.h:1149: constexpr std::vector<_Tp, _Alloc>::const_reference std::vector<_Tp, _Alloc>::operator[](size_type) const [with _Tp = unsigned char; _Alloc = default_init_allocator<unsigned char, std::allocator<unsigned char> >; const_reference = const unsigned char&; size_type = long unsigned int]: Assertion '__n < this->size()' failed.
zsh: IOT instruction (core dumped)  rgbgfx -r 40 -t bg_currents.bin -b 1 -o tileset.2bpp /map.png

assets.zip

The tilemap references tile IDs that aren't present in the tile data (turns out they're loaded separately), but this shouldn't cause a crash.

@Rangi42 Rangi42 added this to the v0.8.1 milestone Jul 25, 2024
@Rangi42 Rangi42 added bug Unexpected behavior / crashes; to be fixed ASAP! rgbgfx This affects RGBGFX labels Jul 25, 2024
@Rangi42
Copy link
Contributor

Rangi42 commented Jul 30, 2024

Note: map.png is the same one from #1427.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected behavior / crashes; to be fixed ASAP! rgbgfx This affects RGBGFX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants